From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 768D59180F for ; Tue, 30 Jan 2024 10:42:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 55F251FABD for ; Tue, 30 Jan 2024 10:42:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 30 Jan 2024 10:42:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 069B8492ED for ; Tue, 30 Jan 2024 10:42:37 +0100 (CET) Date: Tue, 30 Jan 2024 10:42:30 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20231219140306.188937-1-h.duerr@proxmox.com> <20231219140306.188937-2-h.duerr@proxmox.com> In-Reply-To: <20231219140306.188937-2-h.duerr@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1706607727.ezgarw8lmv.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH qemu-server v4 1/2] migration: secure and use source volume names for deactivation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2024 09:42:38 -0000 thanks! On December 19, 2023 3:03 pm, Hannes Duerr wrote: > During migration, the volume names may change if the name is already in > use at the target location. We therefore want to save the original names > so that we can deactivate the original volumes afterwards. >=20 > Signed-off-by: Hannes Duerr > --- > PVE/QemuMigrate.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index b87e47a..8d9b35a 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -1455,6 +1455,8 @@ sub phase3_cleanup { > =20 > my $tunnel =3D $self->{tunnel}; > =20 > + my $sourcevollist =3D PVE::QemuServer::get_vm_volumes($conf); > + > if ($self->{volume_map} && !$self->{opts}->{remote}) { > my $target_drives =3D $self->{target_drive}; > =20 > @@ -1586,8 +1588,7 @@ sub phase3_cleanup { > =20 > # always deactivate volumes - avoid lvm LVs to be active on several = nodes > eval { > - my $vollist =3D PVE::QemuServer::get_vm_volumes($conf); > - PVE::Storage::deactivate_volumes($self->{storecfg}, $vollist); > + PVE::Storage::deactivate_volumes($self->{storecfg}, $sourcevollist); > }; > if (my $err =3D $@) { > $self->log('err', $err); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20