From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A57D1917E5 for ; Tue, 30 Jan 2024 10:38:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83B681F9CA for ; Tue, 30 Jan 2024 10:38:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 30 Jan 2024 10:38:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8AE2F44AAF for ; Tue, 30 Jan 2024 10:38:17 +0100 (CET) Date: Tue, 30 Jan 2024 10:38:10 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20231004073541.104105-1-f.ebner@proxmox.com> In-Reply-To: <20231004073541.104105-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1706607182.44b896xnw8.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage 1/2] plugin schema: improve description of 'shared' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2024 09:38:18 -0000 On October 4, 2023 9:35 am, Fiona Ebner wrote: > It's not clear to users what this property does otherwise. Latest > report from the community forum: >=20 > https://forum.proxmox.com/threads/134393 >=20 > Signed-off-by: Fiona Ebner > --- > src/PVE/Storage/Plugin.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 815773b..dc89d13 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -167,7 +167,9 @@ my $defaultData =3D { > default =3D> "Unlimited for users with Datastore.Allocate privilege= , 5 for other users", > }, > shared =3D> { > - description =3D> "Mark storage as shared.", > + description =3D> "Indicate that this is a single storage which is a= lready accessible by " > + ."all nodes (or all listed in the 'nodes' option). Will not make a loc= al storage " > + ."automatically accessible to other nodes!", I am not sure the 'already' helps here if you don't already (heh) know what 'shared' means. it also doesn't include that it means the same contents on all nodes - a local storage is also accessible on all nodes (or those listed in the 'nodes' option) after all, but it's not shared/has different contents on each node ;) maybe something like Indicate that this storage has the same content on all nodes that can access it. It will not automatically make a local storage shared, it just marks already shared storages as such! ? there's also content in pve-docs that would need to be harmonized after such a change, e.g. the "common storage properties", but maybe also other parts of pvesm.adoc > type =3D> 'boolean', > optional =3D> 1, > }, > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20