From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B4A12C00F0 for ; Wed, 10 Jan 2024 10:19:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E1A031069 for ; Wed, 10 Jan 2024 10:19:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Jan 2024 10:19:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 99C1A49052 for ; Wed, 10 Jan 2024 10:19:05 +0100 (CET) Date: Wed, 10 Jan 2024 10:18:57 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20240109145030.1647121-1-aderumier@odiso.com> <20240109145030.1647121-2-aderumier@odiso.com> In-Reply-To: <20240109145030.1647121-2-aderumier@odiso.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1704878272.void1gps3c.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, launchpad.net] Subject: Re: [pve-devel] [PATCH ceph 1/2] patch: debian/rules: fix build type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2024 09:19:36 -0000 On January 9, 2024 3:50 pm, Alexandre Derumier wrote: > source: https://github.com/ceph/ceph/pull/54891 this was not merged upstream, and I don't think it's needed as per the discussions in both PRs if the other patch is pulled in. > build packages with 'RelWithDebInfo' to avoid to build rocksdb in debug >=20 > This is already the default in ubuntu packages > https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453 > --- > patches/0021-debian-rules-fix-buildtype.patch | 22 +++++++++++++++++++ > patches/series | 1 + > 2 files changed, 23 insertions(+) > create mode 100644 patches/0021-debian-rules-fix-buildtype.patch >=20 > diff --git a/patches/0021-debian-rules-fix-buildtype.patch b/patches/0021= -debian-rules-fix-buildtype.patch > new file mode 100644 > index 000000000..8b6ef6b56 > --- /dev/null > +++ b/patches/0021-debian-rules-fix-buildtype.patch > @@ -0,0 +1,22 @@ > +From 1f4b106d49fc916994d97e273599f75caa904c3b Mon Sep 17 00:00:00 2001 > +From: Mark Nelson > +Date: Thu, 14 Dec 2023 05:19:46 +0000 > +Subject: [PATCH] debian/rules: Fix build_type for massive performance ga= in > + > +Signed-off-by: Mark Nelson > +--- > + debian/rules | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/debian/rules b/debian/rules > +index ed7f4a255ed4b..b28abb7d62788 100755 > +--- a/debian/rules > ++++ b/debian/rules > +@@ -29,6 +29,7 @@ extraopts +=3D -DWITH_PYTHON3=3D3 > + extraopts +=3D -DWITH_CEPHFS_JAVA=3DON > + extraopts +=3D -DWITH_CEPHFS_SHELL=3DON > + extraopts +=3D -DWITH_SYSTEMD=3DON -DCEPH_SYSTEMD_ENV_DIR=3D/etc/defaul= t > ++extraopts +=3D -DCMAKE_BUILD_TYPE=3DRelWithDebInfo > + extraopts +=3D -DWITH_GRAFANA=3DON > + ifeq ($(DEB_HOST_ARCH), amd64) > + extraopts +=3D -DWITH_RBD_RWL=3DON > diff --git a/patches/series b/patches/series > index 67a52ae7c..d9a3ff8f4 100644 > --- a/patches/series > +++ b/patches/series > @@ -13,3 +13,4 @@ > 0016-d-rules-fix-no-restart-on-upgrade.patch > 0017-python3.10-pep-620.patch > 0020-fix-4759-run-ceph-crash-daemon-with-www-data-group-f.patch > +0021-debian-rules-fix-buildtype.patch > \ No newline at end of file > --=20 > 2.39.2 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20