From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C2ECDBFC86 for ; Tue, 9 Jan 2024 10:35:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A80E51534C for ; Tue, 9 Jan 2024 10:35:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 9 Jan 2024 10:35:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE9BF49033 for ; Tue, 9 Jan 2024 10:35:09 +0100 (CET) Date: Tue, 09 Jan 2024 10:35:03 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20231010132452.3340635-1-a.lauterer@proxmox.com> In-Reply-To: <20231010132452.3340635-1-a.lauterer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1704792896.l5l8zw35nb.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2024 09:35:40 -0000 thanks! On October 10, 2023 3:24 pm, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > Reviewed-by: Fiona Ebner > --- > changes since v2: fixed missing trailing comma >=20 > www/manager6/storage/DirEdit.js | 4 ++++ > www/manager6/storage/LVMEdit.js | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEd= it.js > index 7e9ec44d..3e2025fc 100644 > --- a/www/manager6/storage/DirEdit.js > +++ b/www/manager6/storage/DirEdit.js > @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', { > name: 'shared', > uncheckedValue: 0, > fieldLabel: gettext('Shared'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if the underlying file system is alre= ady shared between nodes.'), > + }, > }, > ]; > =20 > diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEd= it.js > index 75c7bdb8..75af6bf7 100644 > --- a/www/manager6/storage/LVMEdit.js > +++ b/www/manager6/storage/LVMEdit.js > @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', { > name: 'shared', > uncheckedValue: 0, > fieldLabel: gettext('Shared'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'), > + }, > }, > ], > }); > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20