From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8DFFF1FF13F for ; Thu, 26 Mar 2026 13:55:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDC7E1170B; Thu, 26 Mar 2026 13:55:34 +0100 (CET) Message-ID: <16fb9fa8-a0a3-4ccb-ab8c-800c23ac2334@proxmox.com> Date: Thu, 26 Mar 2026 13:55:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260325213415.3861690-1-t.lamprecht@proxmox.com> <20260325213415.3861690-2-t.lamprecht@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260325213415.3861690-2-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774529682950 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FLYJ6L6AICX6JT4QMKY47TQT4TXXUNT2 X-Message-ID-Hash: FLYJ6L6AICX6JT4QMKY47TQT4TXXUNT2 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: I feel like we should either rename the existing guest_fs{freeze,thaw}() functions or this one for consistency ('fs_freeze' versus 'fsfreeze'). Am 25.03.26 um 10:33 PM schrieb Thomas Lamprecht: > Add a centralized helper that checks whether guest filesystem > freeze/thaw should be attempted, combining the agent-enabled and > guest-fsfreeze setting checks. This replaces duplicated inline logic > and the scattered '// 1' default fallback across call sites. > > No behavioral change intended, the helper returns the same result as > the previous inline expressions. > > Signed-off-by: Thomas Lamprecht Reviewed-by: Fiona Ebner