From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 1D9911FF16E
	for <inbox@lore.proxmox.com>; Mon, 17 Feb 2025 10:00:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B73161A2B4;
	Mon, 17 Feb 2025 10:00:54 +0100 (CET)
Message-ID: <16d2868d-e1f9-4159-9115-0f141e48d541@proxmox.com>
Date: Mon, 17 Feb 2025 10:00:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexander Abraham <a.abraham@proxmox.com>
References: <20250206122748.21317-1-a.abraham@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250206122748.21317-1-a.abraham@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.021 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager] fix #5076: Added a field for
 OpenID audiences to the configuration UI
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

depending on what restrictions in the backend will be implemented,
we should add the same here, so users get immediate feedback
for wrong values

aside from that LGTM

On 2/6/25 13:27, Alexander Abraham wrote:
> A field was added to the configuration prompt for
> configuring audiences in OpenID realms.
> 
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>   www/manager6/dc/AuthEditOpenId.js | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
> index 544c0de5..7942fa58 100644
> --- a/www/manager6/dc/AuthEditOpenId.js
> +++ b/www/manager6/dc/AuthEditOpenId.js
> @@ -111,6 +111,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
>   		deleteEmpty: '{!isCreate}',
>   	    },
>   	},
> +	{
> +	    xtype: 'proxmoxtextfield',
> +	    name: 'aud',
> +	    fieldLabel: gettext('Audiences'),
> +	    submitEmpty: false,
> +	    cbind: {
> +		deleteEmpty: '{!isCreate}',
> +	    },
> +	},
>       ],
>   
>       initComponent: function() {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel