From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Abraham <a.abraham@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #5076: Added a field for OpenID audiences to the configuration UI
Date: Mon, 17 Feb 2025 10:00:20 +0100 [thread overview]
Message-ID: <16d2868d-e1f9-4159-9115-0f141e48d541@proxmox.com> (raw)
In-Reply-To: <20250206122748.21317-1-a.abraham@proxmox.com>
depending on what restrictions in the backend will be implemented,
we should add the same here, so users get immediate feedback
for wrong values
aside from that LGTM
On 2/6/25 13:27, Alexander Abraham wrote:
> A field was added to the configuration prompt for
> configuring audiences in OpenID realms.
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
> www/manager6/dc/AuthEditOpenId.js | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/www/manager6/dc/AuthEditOpenId.js b/www/manager6/dc/AuthEditOpenId.js
> index 544c0de5..7942fa58 100644
> --- a/www/manager6/dc/AuthEditOpenId.js
> +++ b/www/manager6/dc/AuthEditOpenId.js
> @@ -111,6 +111,15 @@ Ext.define('PVE.panel.OpenIDInputPanel', {
> deleteEmpty: '{!isCreate}',
> },
> },
> + {
> + xtype: 'proxmoxtextfield',
> + name: 'aud',
> + fieldLabel: gettext('Audiences'),
> + submitEmpty: false,
> + cbind: {
> + deleteEmpty: '{!isCreate}',
> + },
> + },
> ],
>
> initComponent: function() {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-17 9:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 12:27 Alexander Abraham
2025-02-17 9:00 ` Dominik Csapak [this message]
2025-06-02 14:34 ` Alexander Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d2868d-e1f9-4159-9115-0f141e48d541@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=a.abraham@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox