From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3A0DD1FF141 for ; Mon, 16 Mar 2026 22:37:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABDD3349CC; Mon, 16 Mar 2026 22:37:49 +0100 (CET) Message-ID: <16c96c98-2b0e-439c-877f-b0dd800b54cd@proxmox.com> Date: Mon, 16 Mar 2026 22:37:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH manager v2 7/7] ui: qga: hide freeze-fs-on-backup conditionally To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260313095534.79526-1-m.sandoval@proxmox.com> <20260313095534.79526-8-m.sandoval@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260313095534.79526-8-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773696994728 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DU7EX2C55PPV4DMQ5GJVUOK4CTQ2YOZ5 X-Message-ID-Hash: DU7EX2C55PPV4DMQ5GJVUOK4CTQ2YOZ5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 13.03.26 um 10:55 schrieb Maximiliano Sandoval: > If the freeze-fs-on-backup key is not explicitly set on the config file > or if it is explicitly enabled (which matches its default) we hide the > corresponding checkbox and hint. > > Note that when the checkbox is unchecked we delete the value from the > config. A consequence of this is that if the deprecated key is > explicitly set `freeze-fs-on-backup=1`, we open the dialog, change some > unrelated setting (so that the OK button becomes sensitive), press OK to > save the settings, then the deprecated key freeze-fs-on-backup key would > be gone from the config. mostly description that I could see from the diff, which can be somewhat OK, but really missing actual rationale here.