From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 0342E1FF16B
for <inbox@lore.proxmox.com>; Thu, 23 Jan 2025 17:39:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 65C9E10F22;
Thu, 23 Jan 2025 17:39:52 +0100 (CET)
Message-ID: <169c861e-aa99-4f78-ae9d-82510c953630@proxmox.com>
Date: Thu, 23 Jan 2025 17:39:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Herzig <d.herzig@proxmox.com>
References: <20250113085608.99498-1-d.herzig@proxmox.com>
<20250113085608.99498-13-d.herzig@proxmox.com>
Content-Language: en-US
From: Friedrich Weber <f.weber@proxmox.com>
In-Reply-To: <20250113085608.99498-13-d.herzig@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.024 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject
button for cdroms
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Hi, I have two small things that I noticed skimming the series (inline).
On 13/01/2025 09:56, Daniel Herzig wrote:
> Eject by setting file to none.
>
> Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
> ---
> www/manager6/qemu/HardwareView.js | 43 +++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index 59e670db..5d1c18a5 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -538,6 +538,45 @@ Ext.define('PVE.qemu.HardwareView', {
> apiurl: '/api2/extjs/' + baseurl,
> });
>
> + let eject_btn = new Proxmox.button.Button({
> + text: gettext('Eject'),
> + disabled: true,
> + selModel: sm,
> + RESTMethod: 'POST',
> + confirmMsg: function(rec) {
> + let warn = gettext("Are you sure you want to eject '{0}' ?");
> + let isofile = rec.data.value.split(",")[0];
Not a frontend expert, but it might be nicer to use something like
PVE.Parser.parsePropertyString to retrieve the ISO name here, instead of
manually splitting the string.
> + let msg = Ext.String.format(warn, isofile);
> + return msg;
This should be html-encoded before displaying, e.g. using Ext.htmlEncode.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel