From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1F9591FA2 for ; Thu, 5 Oct 2023 10:57:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 93EC015821 for ; Thu, 5 Oct 2023 10:57:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 5 Oct 2023 10:57:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 51DE644852 for ; Thu, 5 Oct 2023 10:57:18 +0200 (CEST) Date: Thu, 05 Oct 2023 10:57:11 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230809083739.100024-1-m.frank@proxmox.com> In-Reply-To: <20230809083739.100024-1-m.frank@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1696494070.i92rf99hre.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v6 0/11] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2023 08:57:52 -0000 On August 9, 2023 10:37 am, Markus Frank wrote: > qemu-server patches require pve-guest-common and pve-cluster patches > pve-manager patches require the pve-doc patch >=20 > I did not get virtiofsd to run with run_command without creating zombie > processes after stutdown. > So I replaced run_command with exec for now.=20 > Maybe someone can find out why this happens. some high-level remarks: - in general, seems to work as expected within the limitations of the current virtiofsd - log messages by virtiofsd after the initial startup are lost, adding `--syslog` or otherwise improving the process startup to capture them would be good - I am not sure whether we want to expose this on the GUI just yet - checking earlier when doing a snapshot with RAM might be sensible (since virtiofsd state is not migrateable, it's also not snapshot-saveable and aborts pretty early on, but a nicer error message up front would be even better)[1] - maybe default to ACLs off, or improve detection of support, since having them on but no support means no mounting possible (haven't tested whether the same applies to XATTRs as well) - currently virtiofsd crashing means no recovery until VM is fully stopped and restarted [2] - virtiofsd not responding for whatever reason means NFS-like hanging access in the VM (this should be noted somewhere) - virtiofs shares don't seem to work on older Linux VMs with memory hotplug enabled (it might be good to have some sort of supported/tested-with matrix somewhere so that users don't have to try known-to-not-work combinations..) - bwlimit support once upstream has it would be nice[3] - reboots seem broken (accessing the mount after the reboot hangs), but that might be fixed with a newer upstream version[4] that I'll prepare in the meantime :) noting the build-order/interdependencies would be nice ;) some more smaller nits noted in individual patches 1: https://gitlab.com/virtio-fs/virtiofsd/-/issues/81 2: https://gitlab.com/virtio-fs/virtiofsd/-/issues/62 3: https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/147 4: https://gitlab.com/virtio-fs/virtiofsd/-/commit/ee50078626536b8e25389f01= e7e4be43897418c9