From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3A2A068FDC for ; Tue, 22 Mar 2022 12:19:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F5981D11E for ; Tue, 22 Mar 2022 12:18:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0C8BD1D111 for ; Tue, 22 Mar 2022 12:18:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DA11E4205C for ; Tue, 22 Mar 2022 12:18:41 +0100 (CET) Message-ID: <169274bb-3fe2-80fe-8576-2a364f9fde83@proxmox.com> Date: Tue, 22 Mar 2022 12:18:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, Aaron Lauterer References: <20220314093509.349554-1-a.lauterer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220314093509.349554-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 11:19:13 -0000 Am 14.03.22 um 10:35 schrieb Aaron Lauterer: > This series adds the UI to reassign a disk / volume from one guest to another. > > To avoid button clutter, the Move, Reassing and Resize buttons are moved > into a new submenu called "Disk/Volume Action". > > Patch 3 to 6 are optional. Patch 3 changes the labels for Move, Reassign > and Resize to remove Volume & Disk as we already have this in the > context of the submenu. > > Patch 4 only changes a double negated option. > Patch 5 happend in the process of working on an interface for the > reassign functionality. Since the work of modernizing this componend is > done, why not use it > > Patch 6 changes how we store the max number of MPs possible because I > ran into the issue, that I cannot easily match against the object key if > it is 'mps' instead of 'mp'. > Just nits, so Reviewed-by: Fabian Ebner