From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 35EA983D6 for ; Thu, 27 Jul 2023 10:29:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 161D983A9 for ; Thu, 27 Jul 2023 10:29:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 27 Jul 2023 10:29:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EBAF40C58 for ; Thu, 27 Jul 2023 10:29:23 +0200 (CEST) Date: Thu, 27 Jul 2023 10:29:15 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230717140020.74568-1-f.ebner@proxmox.com> In-Reply-To: <20230717140020.74568-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1690446531.x6pzdc8mm2.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH-SERIES qemu-server] migration: nbd alloc: improve format fallback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2023 08:29:24 -0000 thanks! (once more for the list ;)) On July 17, 2023 4:00 pm, Fiona Ebner wrote: > Currently, remote migration behaves a bit differently, because an > explicitly passed-in format that is not supported by the target > storage is not overwritten with the storage's default format. >=20 > This meant remote live migration with qcow2 to e.g. LVM-thin would not > work, because the code here wrongly tried to allocate a qcow2 disk. >=20 > There also is a qemu_img_format() call which uses the target storage's > $scfg and the source storage's volume name, which is not very nice > either. Change that first and explain how it only affects certain edge > cases and then clean up the whole mess by moving, getting the format > hint to the call side for local migration too. >=20 > Fiona Ebner (2): > migration: alloc nbd disks: base format hint off source storage > migration: alloc nbd disks: fix fall-back for remote live migration >=20 > PVE/API2/Qemu.pm | 1 - > PVE/QemuServer.pm | 32 +++++++++----------------------- > 2 files changed, 9 insertions(+), 24 deletions(-) >=20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20