From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 49171E9A2 for ; Wed, 19 Jul 2023 14:23:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24D5C726B for ; Wed, 19 Jul 2023 14:23:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 14:23:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 32F1B40FD0 for ; Wed, 19 Jul 2023 14:23:01 +0200 (CEST) Date: Wed, 19 Jul 2023 14:22:54 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230719121112.229074-1-d.csapak@proxmox.com> In-Reply-To: <20230719121112.229074-1-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1689769244.oaa5rzfc5s.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 12:23:32 -0000 somewhat plays into #4840 , in that we now no longer do a bogus GET call for the 'null' storage and display a misleading permission error as a result, but there still could be a nice (big?) error message about the general lack of (accessible) storages ;) https://bugzilla.proxmox.com/show_bug.cgi?id=3D4840 On July 19, 2023 2:11 pm, Dominik Csapak wrote: > the default value for combogrids is '', but we often need to set it to > [], to avoid issues with dirty tracking. Fix this by setting it to [] by > default, making it unnecessary to carry the workaround + comment around > in child classes. >=20 > the first patch of pve-manager is a bit unrelated but popped up during > development (can be applied independently) >=20 > the second patch of pve-manager is also a bit independent, but it fixes > wrong dirty tracking in the firewall rule edit window iff the widget > toolkit patch is also present >=20 > the third manager patch depends on the widget toolkit patch >=20 > proxmox-widget-toolkit: >=20 > Dominik Csapak (1): > combogrid: initialze value with [] by default >=20 > src/form/ComboGrid.js | 2 +- > src/form/NetworkSelector.js | 4 ---- > 2 files changed, 1 insertion(+), 5 deletions(-) >=20 > pve-manager: >=20 > Dominik Csapak (3): > ui: ipset: make ip/cidr required > ui: don't set the default value of combogrids to '' > ui: don't set the default value of combogrids to [] >=20 > www/manager6/form/NodeSelector.js | 5 +---- > www/manager6/grid/FirewallRules.js | 2 -- > www/manager6/ha/GroupSelector.js | 1 - > www/manager6/panel/IPSet.js | 2 +- > 4 files changed, 2 insertions(+), 8 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20