From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D0C82E7E7 for ; Wed, 19 Jul 2023 12:23:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B32C557CF for ; Wed, 19 Jul 2023 12:23:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 12:23:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B8D6D40F37 for ; Wed, 19 Jul 2023 12:23:12 +0200 (CEST) Date: Wed, 19 Jul 2023 12:23:06 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230717071518.5184-1-f.ebner@proxmox.com> In-Reply-To: <20230717071518.5184-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1689762177.87i965d5tm.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH container] config permission check: also check access for currently configured bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 10:23:43 -0000 On July 17, 2023 9:15 am, Fiona Ebner wrote: > Relevant when modifying or removing an existing network device. >=20 > Signed-off-by: Fiona Ebner > --- > src/PVE/LXC.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index a531ea5..1e9af0f 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1316,7 +1316,8 @@ sub check_ct_modify_config_perm { > $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Memory'= ]); > } elsif ($opt =3D~ m/^net\d+$/) { > $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Network= ']); > - PVE::LXC::check_bridge_access($rpcenv, $authuser, $newconf->{$opt})= ; > + check_bridge_access($rpcenv, $authuser, $oldconf->{$opt}) if $oldco= nf->{$opt}; > + check_bridge_access($rpcenv, $authuser, $newconf->{$opt}) if $newco= nf->{$opt}; > } elsif ($opt eq 'nameserver' || $opt eq 'searchdomain' || $opt eq 'hos= tname') { > $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Network= ']); > } elsif ($opt eq 'features') { > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20