From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B1BCCE846 for ; Wed, 19 Jul 2023 12:22:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 892A05796 for ; Wed, 19 Jul 2023 12:22:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 12:22:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91BC140F37 for ; Wed, 19 Jul 2023 12:22:56 +0200 (CEST) Date: Wed, 19 Jul 2023 12:22:49 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230717071518.5184-1-f.ebner@proxmox.com> <20230717071518.5184-2-f.ebner@proxmox.com> In-Reply-To: <20230717071518.5184-2-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1689762162.adbv583e25.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, proxmox.com] Subject: [pve-devel] applied: [PATCH qemu-server] api: update: also check access for currently configured bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 10:22:57 -0000 On July 17, 2023 9:15 am, Fiona Ebner wrote: > Relevant when modifying or removing an existing network device. >=20 > Signed-off-by: Fiona Ebner > --- > PVE/API2/Qemu.pm | 13 +++++++++++++ > 1 file changed, 13 insertions(+) >=20 > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 59307133..fd718f93 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1792,6 +1792,13 @@ my $update_vm_api =3D sub { > assert_tag_permissions($vmid, $val, '', $rpcenv, $authuser); > delete $conf->{$opt}; > PVE::QemuConfig->write_config($vmid, $conf); > + } elsif ($opt =3D~ m/^net\d+$/) { > + if ($conf->{$opt}) { > + PVE::QemuServer::check_bridge_access( > + $rpcenv, $authuser, { $opt =3D> $conf->{$opt} }); > + } > + PVE::QemuConfig->add_to_pending_delete($conf, $opt, $force); > + PVE::QemuConfig->write_config($vmid, $conf); > } else { > PVE::QemuConfig->add_to_pending_delete($conf, $opt, $force); > PVE::QemuConfig->write_config($vmid, $conf); > @@ -1860,6 +1867,12 @@ my $update_vm_api =3D sub { > } elsif ($opt eq 'tags') { > assert_tag_permissions($vmid, $conf->{$opt}, $param->{$opt}, $rpce= nv, $authuser); > $conf->{pending}->{$opt} =3D PVE::GuestHelpers::get_unique_tags($p= aram->{$opt}); > + } elsif ($opt =3D~ m/^net\d+$/) { > + if ($conf->{$opt}) { > + PVE::QemuServer::check_bridge_access( > + $rpcenv, $authuser, { $opt =3D> $conf->{$opt} }); > + } > + $conf->{pending}->{$opt} =3D $param->{$opt}; > } else { > $conf->{pending}->{$opt} =3D $param->{$opt}; > =20 > --=20 > 2.39.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20