From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 62F1CE80F for ; Wed, 19 Jul 2023 11:52:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C7844EE2 for ; Wed, 19 Jul 2023 11:52:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 11:52:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5BA2240ECD for ; Wed, 19 Jul 2023 11:52:56 +0200 (CEST) Date: Wed, 19 Jul 2023 11:52:49 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230623124941.895654-1-aderumier@odiso.com> In-Reply-To: <20230623124941.895654-1-aderumier@odiso.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1689760305.7dghxjr68w.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, sdn.pm, qinqplugin.pm, plugin.pm, simpleplugin.pm, vlanplugin.pm] Subject: [pve-devel] applied-series: [PATCH pve-network 0/2] add warning if sdn config in not include in /etc/network/interfaces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 09:52:57 -0000 with first patch correctly attributed to me, since I wrote the change ;) and fixed up the first warn to also be a log_warn. also added two followups, one for the error message, the other for style of the second patch - please shout if you notice something off with either of those! On June 23, 2023 2:49 pm, Alexandre Derumier wrote: > - add a check at config generation > - display specific message on status if vnet is not generated >=20 >=20 > Alexandre Derumier (2): > sdn: config generation : check if interfaces.d/sdn is sourced > zones: status: display specific message if vnet is not generated. >=20 > src/PVE/Network/SDN.pm | 11 ++++++++++- > src/PVE/Network/SDN/Zones/Plugin.pm | 18 +++++++++++++----- > src/PVE/Network/SDN/Zones/QinQPlugin.pm | 8 +------- > src/PVE/Network/SDN/Zones/SimplePlugin.pm | 17 ----------------- > src/PVE/Network/SDN/Zones/VlanPlugin.pm | 8 +------- > 5 files changed, 25 insertions(+), 37 deletions(-) >=20 > --=20 > 2.39.2 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20