From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 175FFA0301 for ; Mon, 12 Jun 2023 16:40:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E447F2549D for ; Mon, 12 Jun 2023 16:39:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Jun 2023 16:39:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A8F324415C for ; Mon, 12 Jun 2023 16:39:32 +0200 (CEST) Date: Mon, 12 Jun 2023 16:39:24 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230607120357.4177891-1-aderumier@odiso.com> In-Reply-To: <20230607120357.4177891-1-aderumier@odiso.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1686580609.i0r1bpxqrb.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied-series: [PATCH-SERIE pve-access-control/pve-manager/pve-guest-common/qemu-server/pve-network] check permissions on local bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2023 14:40:04 -0000 applied the pve-manager and pve-network patches (and your pve-network follow-up, plus some fixes of my own). some more things that might be worthy of a follow-up: - for the ACL panel of a zone, also displaying the vnet + vlan ACLs might be nice - for the ACL panel fo a vnet, also displaying zone ACLs of the vnet zone might be nice this would be similar to how we display datastore permissions in the PBS GUI (I know that other specific permission views in PVE are also lacking this, but for VNETs it's especially visible ;)) - the ACL Add button is not correctly initialized with a disabled state before the first vnet is selected On June 7, 2023 2:03 pm, Alexandre Derumier wrote: > add vnet/localbridge permissions management >=20 > Hi, > as we has discuted some weeks ago, > this patche serie introduce management of acl for vnets && local bridges >=20 > The permission path is: >=20 > /sdn/zones// >=20 > where the local vmbr are in a virtual "localnetwork" zone >=20 > /sdn/zones/localnetwork/ >=20 > Vlans permissions are also handled with > /sdn/zones/// >=20 > if user have permissions on the vnet/tag, he have access to only the spec= ific vlan. > if user have permissions on the vnet with propagate, he have access to al= l vlans of the vnet > if user have permissions on the vnet without propagate, he have access to= bridge only without any vlan >=20 >=20 > I have reworked the sdn zone panel from the tree, to manage permissions > on displayed vnets. (patch 3 && 4 pve-manager) >=20 > some screenshots: >=20 > https://mutulin1.odiso.net/sdnzone-perm.png > https://mutulin1.odiso.net/localzone-perm.png >=20 >=20 >=20 > changelog v2: > - use /vnets/vlan instead /vnets.vlan > - rework the bridge filtering when user have access only to a specific v= lan > - api2 network: always check bridge access if no filter is defined >=20 > changelog v3: > - use /sdn/zones//vnets/vlan instead /sdn/vnets/vnets.vlan > - add SDN.Use permission > - pve-manager: split ui code (could be applied later) > - remove check on zone (it's now propagate with new path) > - move check_vnet_access to pve-guest-common for lxc reuse > - pve-network: fix vnet/tag perm check >=20 > changelog v4: > - qemu-server: check permissions on backup restore > - guest-common: check trunks permissions >=20 > todo: > - implement lxc check permissions >=20 >=20 >=20 > pve-access-control: >=20 > Alexandre Derumier (3): > access control: add /sdn/zones/// path > rpcenvironnment: add check_sdn_bridge > add new SDN.use privilege in PVESDNUser role >=20 > src/PVE/AccessControl.pm | 6 +++++- > src/PVE/RPCEnvironment.pm | 18 ++++++++++++++++++ > 2 files changed, 23 insertions(+), 1 deletion(-) >=20 > pve-manager: >=20 > Alexandre Derumier (4): > api2: network: check permissions for local bridges > api2: cluster: ressources: add "localnetwork" zone > ui: add vnet permissions panel > ui: add permissions management for "localnetwork" zone >=20 > PVE/API2/Cluster.pm | 14 ++ > PVE/API2/Network.pm | 25 ++- > www/manager6/Makefile | 2 + > www/manager6/sdn/Browser.js | 17 +- > www/manager6/sdn/VnetACLView.js | 289 +++++++++++++++++++++++++++ > www/manager6/sdn/ZoneContentPanel.js | 41 ++++ > www/manager6/sdn/ZoneContentView.js | 52 ++++- > 7 files changed, 411 insertions(+), 29 deletions(-) > create mode 100644 www/manager6/sdn/VnetACLView.js > create mode 100644 www/manager6/sdn/ZoneContentPanel.js >=20 > pve-guest-common: >=20 > Alexandre Derumier (1): > helpers : add check_vnet_access >=20 > src/PVE/GuestHelpers.pm | 49 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) >=20 > qemu-server: >=20 > Alexandre Derumier (1): > api2: add check_bridge_access for create/update/clone/restore vm >=20 > PVE/API2/Qemu.pm | 33 +++++++++++++++++++++++++++++---- > 1 file changed, 29 insertions(+), 4 deletions(-) >=20 >=20 > pve-network: >=20 > Alexandre Derumier (1): > get_local_vnets: fix permission path && perm >=20 > PVE/Network/SDN.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20