From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 71E9E9D8C4 for ; Mon, 5 Jun 2023 12:12:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5297F26586 for ; Mon, 5 Jun 2023 12:12:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 5 Jun 2023 12:12:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 47CB348A51 for ; Mon, 5 Jun 2023 12:12:20 +0200 (CEST) Date: Mon, 05 Jun 2023 12:12:12 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20230604233709.1340089-1-aderumier@odiso.com> <20230604233709.1340089-6-aderumier@odiso.com> In-Reply-To: <20230604233709.1340089-6-aderumier@odiso.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1685959517.z2meca7bd4.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-access-control 2/2] rpcenvironnment: add check_sdn_bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2023 10:12:51 -0000 On June 5, 2023 1:37 am, Alexandre Derumier wrote: > check if user have access to 1 vlan of the bridge > or the bridge itself >=20 > Signed-off-by: Alexandre Derumier > --- > src/PVE/RPCEnvironment.pm | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm > index 8586938..fb010cc 100644 > --- a/src/PVE/RPCEnvironment.pm > +++ b/src/PVE/RPCEnvironment.pm > @@ -324,6 +324,23 @@ sub check_full { > } > } > =20 > +sub check_sdn_bridge { > + my ($self, $username, $path, $privs, $noerr) =3D @_; instead of $path, passing in just the bridge ID would also work, and maybe be a nicer interface.. > + > + my $cfg =3D $self->{user_cfg}; > + my $bridge_acl =3D PVE::AccessControl::find_acl_tree_node($cfg->{acl= _root}, $path); > + if ($bridge_acl) { > + my $vlans =3D $bridge_acl->{children}; > + for my $vlan (keys %$vlans) { > + my $vlanpath =3D "$path/$vlan"; > + return 1 if $self->check_any($username, $vlanpath, $privs, $noerr); > + } > + # check propagate on bridge itself > + return 1 if $self->check_any($username, $path, $privs, $noerr); this doesn't actually check propagation though? for that you could either: - use $self->permissions (it returns the propagate bit) - query a non-existing vlan child path with check_any > + } > + return; > +} > + > sub check_user_enabled { > my ($self, $user, $noerr) =3D @_; > =20 > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20