From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D05D19990C for ; Tue, 2 May 2023 10:30:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C58B2E33A for ; Tue, 2 May 2023 10:30:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 2 May 2023 10:30:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C0E846E5F for ; Tue, 2 May 2023 10:30:14 +0200 (CEST) Date: Tue, 02 May 2023 10:30:07 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion , Thomas Lamprecht References: <20230425165233.3745210-1-aderumier@odiso.com> <20230425165233.3745210-3-aderumier@odiso.com> <1682514292.71raew01tr.astroid@yuna.none> <1682580098.xwye6zkp88.astroid@yuna.none> <6999b2267fb55cad2a60675c58051a8ef8258284.camel@groupe-cyllene.com> <1682671458.u9jiyz5qe3.astroid@yuna.none> <915b0a62-d3ad-cd94-e2c1-b4f9840b5034@proxmox.com> In-Reply-To: <915b0a62-d3ad-cd94-e2c1-b4f9840b5034@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1683015667.t7gn3po142.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 qemu-server 2/2] remote-migration: add target-cpu param X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 May 2023 08:30:45 -0000 On April 29, 2023 9:57 am, Thomas Lamprecht wrote: > Am 28/04/2023 um 11:12 schrieb Fabian Gr=C3=BCnbichler: >>> It's was more about "offline" term, because we don't offline the source >>> vm until the disk migration is finished. (to reduce downtime) >>> More like "online-restart" instead "offline". >>> >>> Offline for me , is really, we shut the vm, then do the disk migration. >> hmm, I guess how you see it. for me, online means without interruption, >> anything else is offline =F0=9F=98=84 but yeah, naming is hard, as alway= s =F0=9F=98=89 >=20 > FWIW, in Proxmox Container land that's currently basically the "most onli= ne" > it gets, and there it's named "restore migration" =E2=80=93 at least if w= e go for the > "clean reboot for actual moving the guest over" approach. "restart", you meant? yes, but it's explicitly not "online", it's a second parameter besides that called "restart" that cannot be combined with "online" (nothing can, since setting "online" leads to a hard error if the VM is running). it also does the following: - stop CT on source node (if running) - storage migration (via pve-storage) - start CT again on target node (if previously running) similar to this series, but not quite: - start storage migration (via pve-storage for unused/.., live via qemu for currently used volumes) - wait for storage migration convergence - stop VM on source node / complete block job (details still to be hashed o= ut) - start VM on target node so naming what this series does "restart" might be confusing, since the most fundamental part is different (the downtime is only for the restart part, as opposed to for restart+storage migration).