From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB2796981F for ; Tue, 27 Jul 2021 16:03:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8A881A990 for ; Tue, 27 Jul 2021 16:03:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 228E61A981 for ; Tue, 27 Jul 2021 16:03:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E18604287F for ; Tue, 27 Jul 2021 16:03:17 +0200 (CEST) Message-ID: <166e8460-05ff-5791-6103-7e2a5fc796d4@proxmox.com> Date: Tue, 27 Jul 2021 16:03:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20210727133709.1311314-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210727133709.1311314-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.617 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.438 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container] vmstatus: include detected IP address of running containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2021 14:03:48 -0000 On 27.07.21 15:37, Oguz Bektas wrote: > add a helper 'find_lxc_ip_address' to fetch IP address of container from > its network namespace using lxc-info. > > for the moment it can be queried with the pct tool: > $ pct status 1000 --verbose > cpu: 0 > cpus: 1 > disk: 6422528 > diskread: 368640 > diskwrite: 0 > ipaddress: 192.168.31.83 <---- > maxdisk: 4294967296 > maxmem: 536870912 > maxswap: 536870912 > mem: 864256 > name: CT1000 > netin: 3281265 > netout: 15794 > pid: 34897 > status: running > swap: 94208 > type: lxc > uptime: 11088 > vmid: 1000 > what about multiple, you only print the last match which is quite confusing... And why use `lxc-info`, this is called very often and we know about setups with 1500+ CTs on a single host, so it'd be good to check if adding 1000s forks every status call could be avoided. > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC.pm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 139f901..e7804e0 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -247,6 +247,8 @@ sub vmstatus { > > next if !$pid; # skip stopped CTs > > + $d->{ipaddress} = find_lxc_ip_address($vmid); You forgot to add this to the API/CLI return schema in $PVE::LXC::vmstatus_return_properties, which may highly probably actually want to be an array... > + > my $proc_pid_stat = PVE::ProcFSTools::read_proc_pid_stat($pid); > $d->{uptime} = int(($uptime - $proc_pid_stat->{starttime}) / $clock_ticks); # the method lxcfs uses > > @@ -397,6 +399,20 @@ sub open_ppid { > return ($ppid, $fd); > } > > +sub find_lxc_ip_address { > + my ($vmid) = @_; > + > + my $ip = undef; as said above, needs to be an array.. > + > + my $parser = sub { > + my $line = shift; > + $ip = $1 if $line =~ m/^IP:\s+(.*)$/; > + }; > + > + PVE::Tools::run_command(['lxc-info', '-n', $vmid, '--ips'], outfunc => $parser, errfunc => sub {}); > + return $ip; > +} > + > # Note: we cannot use Net:IP, because that only allows strict > # CIDR networks > sub parse_ipv4_cidr { >