From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DD9A28DA55 for ; Wed, 9 Nov 2022 13:15:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC9B01BF83 for ; Wed, 9 Nov 2022 13:15:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 13:15:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 21687422A0 for ; Wed, 9 Nov 2022 13:15:05 +0100 (CET) Date: Wed, 09 Nov 2022 13:14:58 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220920125041.3636561-1-d.csapak@proxmox.com> <20220920125041.3636561-18-d.csapak@proxmox.com> In-Reply-To: <20220920125041.3636561-18-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1667995675.8a5847bwnj.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.141 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm] Subject: Re: [pve-devel] [PATCH qemu-server v3 08/13] PVE/API2/Qemu: add permission checks for mapped pci devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 12:15:06 -0000 On September 20, 2022 2:50 pm, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/API2/Qemu.pm | 54 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 52 insertions(+), 2 deletions(-) >=20 > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 7afd7a4..d6d393f 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -26,6 +26,7 @@ use PVE::QemuServer::Drive; > use PVE::QemuServer::ImportDisk; > use PVE::QemuServer::Monitor qw(mon_cmd); > use PVE::QemuServer::Machine; > +use PVE::QemuServer::PCI; > use PVE::QemuServer::USB qw(parse_usb_device); > use PVE::QemuMigrate; > use PVE::RPCEnvironment; > @@ -603,6 +604,26 @@ my $check_vm_create_usb_perm =3D sub { > return 1; > }; > =20 > +my $check_vm_create_hostpci_perm =3D sub { > + my ($rpcenv, $authuser, $vmid, $pool, $param) =3D @_; > + > + return 1 if $authuser eq 'root@pam'; > + > + foreach my $opt (keys %{$param}) { > + next if $opt !~ m/^hostpci\d+$/; > + > + my $device =3D PVE::JSONSchema::parse_property_string('pve-qm-hostpci',= $param->{$opt}); > + if ($device->{host} !~ m/:/) { while thinking about the priv patch I decided to check out the ACL handling= as well - sorry for not asking earlier about this aspect! would it make sense to have a prefix for "ID of mapped hardware" instead of claiming "everything that doesn't contain ':'" as namespace? the same also applies to the USB ACL checks and the other checks in this pa= tch.. > + $rpcenv->check_full($authuser, "/hardware/$device->{host}", ['Hardw= are.Use']); this and similar sites would then also be more explicit: my $hw_id =3D ..; # extract actual ID $rpvenv->check_full($authuser, "/hardware/$hw_id", ['Hardware.Use']); > + $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.HWType'= ]); > + } else { > + die "only root can set '$opt' config for non-mapped devices\n"; > + } > + } > + > + return 1; > +}; > + > > [...]