From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 42ABE96BA for ; Tue, 26 Apr 2022 12:16:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4089C1A261 for ; Tue, 26 Apr 2022 12:16:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5D8AF1A257 for ; Tue, 26 Apr 2022 12:16:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 330BC42B96 for ; Tue, 26 Apr 2022 12:16:14 +0200 (CEST) Date: Tue, 26 Apr 2022 12:16:08 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220425123112.37261-1-f.ebner@proxmox.com> In-Reply-To: <20220425123112.37261-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1650966361.6lu2wu8d3q.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.171 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemumigrate.pm, proxmox.com] Subject: [pve-devel] applied-series: [PATCH qemu-server 1/2] migrate: add log for guest fstrim X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 10:16:15 -0000 thanks! On April 25, 2022 2:31 pm, Fabian Ebner wrote: > and make a failure noticable. >=20 > Suggested-by: Fabian Gr=C3=BCnbichler > Signed-off-by: Fabian Ebner > --- > PVE/QemuMigrate.pm | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) >=20 > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 891edfb2..c293e294 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -1170,14 +1170,23 @@ sub phase3_cleanup { > $self->{errors} =3D 1; > } > } > + } > =20 > - if ( > - $self->{storage_migration} > - && PVE::QemuServer::parse_guest_agent($conf)->{fstrim_cloned_disks} > - && $self->{running} > - ) { > + if ( > + $self->{storage_migration} > + && PVE::QemuServer::parse_guest_agent($conf)->{fstrim_cloned_disks} > + && $self->{running} > + ) { > + if (!$self->{vm_was_paused}) { > + $self->log('info', "issuing guest fstrim"); > my $cmd =3D [@{$self->{rem_ssh}}, 'qm', 'guest', 'cmd', $vmid, 'fstrim= ']; > - eval{ PVE::Tools::run_command($cmd, outfunc =3D> sub {}, errfunc =3D> = sub {}) }; > + eval { PVE::Tools::run_command($cmd, outfunc =3D> sub {}, errfunc =3D>= sub {}) }; > + if (my $err =3D $@) { > + $self->log('err', "fstrim failed - $err"); > + $self->{errors} =3D 1; > + } > + } else { > + $self->log('info', "skipping guest fstrim, because VM is paused"); > } > } > } > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20