From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6398DC63E for ; Mon, 11 Apr 2022 12:00:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5600E2E37 for ; Mon, 11 Apr 2022 12:00:22 +0200 (CEST) Received: from mx1.tetaneutral.net (mx1.tetaneutral.net [IPv6:2a03:7220:8081:5300::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 894672E2C for ; Mon, 11 Apr 2022 12:00:21 +0200 (CEST) Received: by mx1.tetaneutral.net (Postfix, from userid 109) id 3FF918C0C9; Mon, 11 Apr 2022 12:00:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mx1.tetaneutral.net X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, FSL_HELO_NON_FQDN_1 autolearn=ham autolearn_force=no version=3.4.2 Received: from lgnuc (ip165.tetaneutral.net [IPv6:2a03:7220:8080:a500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.tetaneutral.net (Postfix) with ESMTPS id B0D7F8C0C2; Mon, 11 Apr 2022 12:00:05 +0200 (CEST) Message-ID: <1649671205.6346.35.camel@guerby.net> From: Laurent GUERBY To: Matthias Heiserer , Proxmox VE development discussion Date: Mon, 11 Apr 2022 12:00:05 +0200 In-Reply-To: <9881cc3c-e316-2f8d-2be4-cb36e3161045@proxmox.com> References: <1649408819.6346.22.camel@guerby.net> <9881cc3c-e316-2f8d-2be4-cb36e3161045@proxmox.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] New API endpoint to manage snippets / bugzilla 2208 / updated patch but missing something, need help X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2022 10:00:52 -0000 On Mon, 2022-04-11 at 11:03 +0200, Matthias Heiserer wrote: > Hi, > > please take a look at our developer documentation. > https://pve.proxmox.com/wiki/Developer_Documentation > > Using `git format-patch` makes applying the changes a whole lot > easier :) > > As far as I can tell from a quick test, your changes seem to work. > Would you mind using `pvesh create` to test? > > If it doesn't work there either, make sure to include the exact  > command/code you used so people can try to reproduce the problem. > Hi, Thanks for the pointer I'll give it a spin later this week. I opened a bugzilla on the "501" error since I'm able to reproduce the "upload small file" bug on an unmodified PVE 7: https://bugzilla.proxmox.com/show_bug.cgi?id=3990 Since snippets yaml are likely to be small they'll be impacted by this prior bug. Sincerely, Laurent