From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.gruenbichler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4BD02BB4A for <pve-devel@lists.proxmox.com>; Fri, 8 Apr 2022 09:44:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44CC2BC5E for <pve-devel@lists.proxmox.com>; Fri, 8 Apr 2022 09:44:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6C7ADBC54 for <pve-devel@lists.proxmox.com>; Fri, 8 Apr 2022 09:44:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 40996458F0 for <pve-devel@lists.proxmox.com>; Fri, 8 Apr 2022 09:44:42 +0200 (CEST) Date: Fri, 08 Apr 2022 09:44:35 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20220322073412.30562-1-h.laimer@proxmox.com> In-Reply-To: <20220322073412.30562-1-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1649403675.3sjssov72n.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.224 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH-SERIES] move jobs from pve-manager X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 08 Apr 2022 07:44:43 -0000 On March 22, 2022 8:34 am, Hannes Laimer wrote: > The VZDump plugin was moved to pve-guest-common because it is used by > both CTs and VMs. Since the Jobs.pm contains helpers that depend on the > VZDump plugin, it was also moved to pve-guest-common. The base jobs > plugin was moved to pve-cluster since it does not really depend on > anything and might be used in many places. >=20 > Version bumps are needed. actually (although it's pretty obvious in this case given the=20 description above and the diff stats below ;): version bumps, versioned dependencies and breaks+replaces since files=20 are moved from one package to another while keeping their paths! pve-manager depends on bumped pve-cluster and bumped pve-guest-common (usin= g moved files) pve-guest-common depends on bumped pve-cluster (using moved files) pve-guest-common breaks & replaces old pve-manager (taking over files) pve-cluster breaks & replaces old pve-manager (taking over file) replace pve-cluster with new binary package possibly (see patch #1) but alas, this requires some more work/thought anyway - see patch #2. >=20 > pve-cluster: >=20 > Hannes Laimer (1): > jobs: move base plugin from pve-manager >=20 > data/PVE/Jobs/Makefile | 11 ++++ > data/PVE/Jobs/Plugin.pm | 101 +++++++++++++++++++++++++++++++++++++ > data/PVE/Makefile | 2 +- > debian/pve-cluster.install | 1 + > 4 files changed, 114 insertions(+), 1 deletion(-) > create mode 100644 data/PVE/Jobs/Makefile > create mode 100644 data/PVE/Jobs/Plugin.pm >=20 >=20 > pve-guest-common: >=20 > Hannes Laimer (1): > jobs: move VZDump plugin from pve-manager >=20 > src/Makefile | 4 + > src/PVE/Jobs.pm | 282 +++++++++++++++++++++++++++++++++++++++++ > src/PVE/Jobs/VZDump.pm | 87 +++++++++++++ > 3 files changed, 373 insertions(+) > create mode 100644 src/PVE/Jobs.pm > create mode 100644 src/PVE/Jobs/VZDump.pm >=20 >=20 > pve-manager: >=20 > Hannes Laimer (1): > jobs: move to pve-cluster and pve-guest-common >=20 > PVE/Jobs.pm | 282 --------------------------------------------- > PVE/Jobs/Makefile | 16 --- > PVE/Jobs/Plugin.pm | 101 ---------------- > PVE/Jobs/VZDump.pm | 87 -------------- > PVE/Makefile | 3 +- > 5 files changed, 1 insertion(+), 488 deletions(-) > delete mode 100644 PVE/Jobs.pm > delete mode 100644 PVE/Jobs/Makefile > delete mode 100644 PVE/Jobs/Plugin.pm > delete mode 100644 PVE/Jobs/VZDump.pm >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20