From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A008E6AF35 for ; Thu, 17 Mar 2022 13:33:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C83DF3EA8 for ; Thu, 17 Mar 2022 13:33:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0CE423E9D for ; Thu, 17 Mar 2022 13:33:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D98F9420B8 for ; Thu, 17 Mar 2022 13:33:31 +0100 (CET) Date: Thu, 17 Mar 2022 13:33:25 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220311112504.595964-1-o.bektas@proxmox.com> <20220311112504.595964-7-o.bektas@proxmox.com> In-Reply-To: <20220311112504.595964-7-o.bektas@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647520117.0647nzhqq2.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.181 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodes.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 manager 06/12] api: update comment about login prompt for non-root users X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 12:33:33 -0000 On March 11, 2022 12:24 pm, Oguz Bektas wrote: > we have a SU privilege now, but we still drop to a login prompt for such > users. >=20 > Signed-off-by: Oguz Bektas > --- > PVE/API2/Nodes.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index 655493a3..0c3de231 100644 > --- a/PVE/API2/Nodes.pm > +++ b/PVE/API2/Nodes.pm > @@ -870,7 +870,7 @@ sub get_shell_command { > $cmd =3D [ '/bin/login', '-f', 'root' ]; > } > } else { > - # non-root must always login for now, we do not have a superuser role! > + # non-root must always login, even with SU privilege it would be nicer to check this early on as well with a proper error=20 message - all of temrproxy, vncshell, spiceshell allow passing in a cmd=20 ('login', 'upgrade', or 'ceph_install'), and only 'upgrade' is checked=20 there for being root@pam only. so if a user calls those with=20 'ceph_install', they'd be dropped in a login prompt instead without any=20 indication why.. > $cmd =3D [ '/bin/login' ]; > } > return $cmd; > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20