From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 624996AEB9 for ; Thu, 17 Mar 2022 13:18:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FDB53ADB for ; Thu, 17 Mar 2022 13:18:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8921A3AD2 for ; Thu, 17 Mar 2022 13:18:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5FF2046EA8 for ; Thu, 17 Mar 2022 13:18:48 +0100 (CET) Date: Thu, 17 Mar 2022 13:18:40 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220311112504.595964-1-o.bektas@proxmox.com> <20220311112504.595964-5-o.bektas@proxmox.com> In-Reply-To: <20220311112504.595964-5-o.bektas@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647519357.o9410zmz77.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.182 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, backup.pm] Subject: Re: [pve-devel] [PATCH v2 manager 04/12] api: backup: allow SUs to use 'tmpdir', 'dumpdir' and 'script' options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 12:18:49 -0000 On March 11, 2022 12:24 pm, Oguz Bektas wrote: > previously limited to root@pam; we can allow SUs to use these options if > they have the privilege on the whole API path. >=20 > Signed-off-by: Oguz Bektas > --- > PVE/API2/Backup.pm | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm > index 9953a704..142eddd1 100644 > --- a/PVE/API2/Backup.pm > +++ b/PVE/API2/Backup.pm > @@ -43,8 +43,13 @@ my $assert_param_permission =3D sub { > my ($param, $user) =3D @_; > return if $user eq 'root@pam'; # always OK > =20 > + my $rpcenv =3D PVE::RPCEnvironment::get(); > + # we need to have SU privs on / path for these options to be used sa= fely that comment is bogus - having some privileges doesn't make this=20 options 'safe', it's the other way round - we require this privilege=20 because the options are not safe. the check call itself and the messages=20 below are already very clear, I don't think we need a comment here at=20 all? but if you think we do, a simple=20 # SuperUser always OK like for root above would suffice.. > + my $is_superuser =3D $rpcenv->check($user, "/", ['SuperUser'], 1); > + return if $is_superuser; return if $rpcenv... > + > for my $key (qw(tmpdir dumpdir script)) { > - raise_param_exc({ $key =3D> "Only root may set this option."}) if exist= s $param->{$key}; > + raise_param_exc({ $key =3D> "Only superusers may set this option."}) if= exists $param->{$key}; > } > }; > =20 > @@ -142,7 +147,7 @@ __PACKAGE__->register_method({ > description =3D> "Create new vzdump backup job.", > permissions =3D> { > check =3D> ['perm', '/', ['Sys.Modify']], > - description =3D> "The 'tmpdir', 'dumpdir' and 'script' parameters are a= dditionally restricted to the 'root\@pam' user.", > + description =3D> "The 'tmpdir', 'dumpdir' and 'script' parameters are a= dditionally restricted to superusers.", > }, > parameters =3D> { > additionalProperties =3D> 0, > @@ -344,7 +349,7 @@ __PACKAGE__->register_method({ > description =3D> "Update vzdump backup job definition.", > permissions =3D> { > check =3D> ['perm', '/', ['Sys.Modify']], > - description =3D> "The 'tmpdir', 'dumpdir' and 'script' parameters are a= dditionally restricted to the 'root\@pam' user.", > + description =3D> "The 'tmpdir', 'dumpdir' and 'script' parameters are a= dditionally restricted to superusers.", > }, > parameters =3D> { > additionalProperties =3D> 0, > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20