From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 94A9D6ABC1 for ; Thu, 17 Mar 2022 10:37:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E403F7E for ; Thu, 17 Mar 2022 10:36:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EE110F75 for ; Thu, 17 Mar 2022 10:36:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A19B942886 for ; Thu, 17 Mar 2022 10:36:48 +0100 (CET) Date: Thu, 17 Mar 2022 10:36:36 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220311112504.595964-1-o.bektas@proxmox.com> <20220311112504.595964-2-o.bektas@proxmox.com> In-Reply-To: <20220311112504.595964-2-o.bektas@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647509557.oe1ee6ysu9.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.183 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 docs 01/12] pveum: add SU privilege and SA role X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 09:37:19 -0000 On March 11, 2022 12:24 pm, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > pveum.adoc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/pveum.adoc b/pveum.adoc > index a5c8906..5ad111a 100644 > --- a/pveum.adoc > +++ b/pveum.adoc > @@ -684,7 +684,8 @@ Roles > A role is simply a list of privileges. Proxmox VE comes with a number > of predefined roles, which satisfy most requirements. > =20 > -* `Administrator`: has full privileges > +* `SuperAdministrator`: has full privileges (equivalent to 'root@pam', b= e careful when giving this role to a user!) > +* `Administrator`: has all privileges except `SuperUser` I'd make the descriptions shorter and add the warnings as proper=20 warnings. * `SuperAdministrator`: has full privileges including `SuperUser` > * `NoAccess`: has no privileges (used to forbid access) > * `PVEAdmin`: can do most tasks, but has no rights to modify system sett= ings (`Sys.PowerMgmt`, `Sys.Modify`, `Realm.Allocate`) > * `PVEAuditor`: has read only access > @@ -727,6 +728,7 @@ We currently support the following privileges: > =20 > Node / System related privileges:: > =20 > +* `SuperUser`: modify root-only configuration options (dangerous! don't = give this privilege to untrusted users) > * `Permissions.Modify`: modify access permissions > * `Sys.PowerMgmt`: node power management (start, stop, reset, shutdown, = ...) > * `Sys.Console`: console access to node SuperUser is not Node/System related though? it also affects guest=20 operations for example, so I'd add it either up front or last on its=20 own, with a warning and longer description (allows root stuff, might=20 require other basic privs in addition to SuperUser, danger danger,=20 certain actions on users with this privs are restricted, ..)