From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 717E16A6BB for ; Wed, 16 Mar 2022 13:25:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 642EC27881 for ; Wed, 16 Mar 2022 13:25:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8BA3B27878 for ; Wed, 16 Mar 2022 13:25:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 690F5463EE for ; Wed, 16 Mar 2022 13:25:04 +0100 (CET) Date: Wed, 16 Mar 2022 13:24:55 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220311112504.595964-1-o.bektas@proxmox.com> <20220311112504.595964-13-o.bektas@proxmox.com> In-Reply-To: <20220311112504.595964-13-o.bektas@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647433007.vnxlnzue1f.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.184 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 access-control 12/12] api: acl: only allow granting SU privilege if user already has it X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 12:25:35 -0000 a similar patch for adding/editing roles is missing (else, this is=20 trivially worked around by giving myself 'CustomRole' that doesn't have=20 SU, then editing that role to add SU to it). On March 11, 2022 12:25 pm, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > v1->v2: > * added new after discussion with fabian about security implications of > allowing SU privilege to be granted by users with Permissions.Modify >=20 > src/PVE/API2/ACL.pm | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/src/PVE/API2/ACL.pm b/src/PVE/API2/ACL.pm > index 857c672..d415334 100644 > --- a/src/PVE/API2/ACL.pm > +++ b/src/PVE/API2/ACL.pm > @@ -134,6 +134,10 @@ __PACKAGE__->register_method ({ > code =3D> sub { > my ($param) =3D @_; > =20 > + my $rpcenv =3D PVE::RPCEnvironment::get(); > + my $authuser =3D $rpcenv->get_user(); > + my $is_superuser =3D $rpcenv->check($authuser, $param->{path}, ['SuperU= ser'], 1); this does not include checking whether propagate is set or not, but this=20 API path allows setting the propagate flag on an ACL (so if $authuser=20 has SU on $param->{path} *without propagation*, it could now give away SU=20 on $param->{path} *with propagation*, thus extending SU to arbitrary sub=20 paths). > + > if (!($param->{users} || $param->{groups} || $param->{tokens})) { > raise_param_exc({ map { $_ =3D> "either 'users', 'groups' or 'token= s' is required." } qw(users groups tokens) }); > } > @@ -160,6 +164,11 @@ __PACKAGE__->register_method ({ > die "role '$role' does not exist\n" > if !$cfg->{roles}->{$role}; > =20 > + my $role_privs =3D $cfg->{roles}->{$role}; > + my $role_contains_superuser =3D grep { $_ eq 'SuperUser' } keys %$= role_privs; > + die "only superusers can grant this role!\n" > + if !$is_superuser && $role_contains_superuser; > + > foreach my $group (split_list($param->{groups})) { > =20 > die "group '$group' does not exist\n" > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20