From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B76666A5B6 for ; Wed, 16 Mar 2022 11:29:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9BFB326657 for ; Wed, 16 Mar 2022 11:29:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E02132664E for ; Wed, 16 Mar 2022 11:29:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AF7AB46DE1 for ; Wed, 16 Mar 2022 11:29:08 +0100 (CET) Date: Wed, 16 Mar 2022 11:29:00 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Fabian Ebner , pve-devel@lists.proxmox.com References: <20220309100919.31512-1-f.ebner@proxmox.com> <1647272668.dywyj5zjzo.astroid@nora.none> <81032125-67bc-d2ec-e2dd-cb7017ec1c11@proxmox.com> In-Reply-To: <81032125-67bc-d2ec-e2dd-cb7017ec1c11@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647425717.88oufe3boz.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.185 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] partially-applied: [PATCH-SERIES v12 qemu-server/manager] API for disk import and OVF X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 10:29:09 -0000 On March 16, 2022 11:00 am, Fabian Ebner wrote: > Am 14.03.22 um 16:57 schrieb Fabian Gr=C3=BCnbichler: >> applied qemu-server patches except 11 and 14-16, see comments on=20 >> indivudal patches. >>=20 >=20 > Thanks a lot for the review/feedback! >=20 >> some unrelated but possibly fix-able as followup things I noticed: >> - cloning a running VM with an EFI disk fails, the EFI disk is not=20 >> mirrorable (so we need another check like for TPM state?) >=20 > Isn't that just when the target storage allocates a different-sized > disk, i.e. https://bugzilla.proxmox.com/show_bug.cgi?id=3D3227 no, was my fault (the VM in question had an efi disk, but was not booted=20 using UEFI). probably should add a check for that as well though,=20 unrelated to this series (move disk is also affected, and I guess=20 live-migration as well..) >> - cancelling a running clone doesn't cleanup properly (stops with trying= =20 >> to aquire lock and leaves the target VM locked & existing) >>=20 >=20 > Will take a look. >=20 the exact log messages are not always the same, but the target remains=20 around locked with whatever state it managed to get to (and the task=20 stopped with 'unexpected status').