From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C4166A13B for ; Tue, 15 Mar 2022 13:35:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B68C1E2E6 for ; Tue, 15 Mar 2022 13:34:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A2A231E2DD for ; Tue, 15 Mar 2022 13:34:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 79C5E4591E for ; Tue, 15 Mar 2022 13:34:53 +0100 (CET) Date: Tue, 15 Mar 2022 13:34:45 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20220223120359.45928-1-f.ebner@proxmox.com> In-Reply-To: <20220223120359.45928-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1647347554.hjp2gv24x9.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.186 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, snapshot.pm, qemu.pm, lxc.pm] Subject: [pve-devel] applied-series: [PATCH-SERIES v4 container/qemu-server] fix #3424: wait for active replication when deleting a snapshot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2022 12:35:24 -0000 with some small follow-ups as discussed off-list: - improve error messages in case of failure to acquire lock - downgrade die to warn in pve-container vzdump patch, since it's not=20 fatal On February 23, 2022 1:03 pm, Fabian Ebner wrote: > Avoid that an attempt to remove a snapshot that's actively used by > replication leads to a partially (or not) removed snapshot and locked > guest. >=20 > I decided to make the checks at the call sides, because passing the > log function and timeout to snapshot_delete felt awkward as they > would only be used for obtaining the lock. >=20 > Changes from v3: > * Unconditionally take the lock, to not race with replication job > creation and future-proofing. > * Only log in the case with the long timeout if we can't obtain > the lock quickly. > * Make message more general, because it might be another snapshot > removal operation holding the lock. >=20 >=20 > container: >=20 > Fabian Ebner (2): > partially fix #3424: vzdump: cleanup: wait for active replication > fix #3424: api: snapshot delete: wait for active replication >=20 > src/PVE/API2/LXC/Snapshot.pm | 11 ++++++++++- > src/PVE/VZDump/LXC.pm | 20 ++++++++++++++++++-- > 2 files changed, 28 insertions(+), 3 deletions(-) >=20 >=20 > qemu-server: >=20 > Fabian Ebner (1): > fix #3424: api: snapshot delete: wait for active replication >=20 > PVE/API2/Qemu.pm | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20