From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1761DF627 for ; Fri, 21 Jul 2023 16:20:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED54730163 for ; Fri, 21 Jul 2023 16:20:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 21 Jul 2023 16:20:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C8E84255F for ; Fri, 21 Jul 2023 16:20:28 +0200 (CEST) Message-ID: <1646923e-2c36-46c6-89dc-5ab3a8e97c17@proxmox.com> Date: Fri, 21 Jul 2023 16:20:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Christoph Heiss References: <20230713094941.475486-1-c.heiss@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230713094941.475486-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] partially-applied: [PATCH installer 0/7] tui: add ZFS/Btrfs RAID setup checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2023 14:20:29 -0000 On 13/07/2023 11:49, Christoph Heiss wrote: > This introduces the same checks when creating a RAID setup for ZFS and > Btrfs as in the GUI installer. > > The main benefit is that the user now gets an error before the setup > dialog can even be closed, instead of during the install process. > > Patch #1, #2 and #3 are some cleanups/fixes for things I noticed along > the way, #4 and #5 are prepatory patches. #6 then implements the actual > functionality. > > Additionally, #7 contains unit tests for all the logic code paths that > were added, to ensure this cannot be accidentally be regressed. > > pve-installer: > > Christoph Heiss (7): > gitignore: add cd-info.test > tui: fix small typo in error message applied above two, but below cause build/test failures or do not apply (anymore). > tui: simplify duplicate disk checking logic > tui: deserialize boot type and disk blocksize from runtime env info > tui: improve bootdisk dialog error handling > tui: add RAID setup checks for ZFS/Btrfs > tui: add tests for RAID setup checks