From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 26D766C25B for ; Wed, 22 Sep 2021 09:28:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AA9F163EB for ; Wed, 22 Sep 2021 09:28:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B049163DC for ; Wed, 22 Sep 2021 09:28:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 211B5449DB for ; Wed, 22 Sep 2021 09:28:34 +0200 (CEST) Message-ID: <164656e3-710f-62c2-3284-7ecb240c9a95@proxmox.com> Date: Wed, 22 Sep 2021 09:27:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210625123205.65641-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210625123205.65641-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.251 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemumigrate.pm] Subject: [pve-devel] applied: [PATCH qemu-server] migrate: use correct target storage id for checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2021 07:28:35 -0000 On 25.06.21 14:32, Fabian Ebner wrote: > The '--targetstorage' parameter does not apply to shared storages. > > Example for a problem solved with the enabled check: Given a VM with > images only on a shared storage 'storeA', not available on the target > node (i.e. restricted by the nodes property). Then using > '--targetstorage storeB' would make offline migration suddenly > "work", but of course the disks would not be accessible and then > trying to migrate back would fail... > > Example for a problem solved with the content type check: if a > VM had a shared ISO image, and there was a '--targetstorage storeA' > option, availablity of the 'iso' content type is checked for > 'storeA', which is wrong as the ISO would not be moved to that > storage. > > Signed-off-by: Fabian Ebner > --- > > The first kind of issue is also present in stable-6. > > PVE/QemuMigrate.pm | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > applied, thanks! But as talked off-list: it makes sense to honor a mapping from a shared source storage to any target storage too, if explicitly asked for. But, that'll be easier to do once Fabians remote migration series gets merged, as there the building blocks for such a "feature" are already present.