From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 887E161B12 for ; Tue, 18 Jan 2022 10:56:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7DE7B27B30 for ; Tue, 18 Jan 2022 10:56:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9D06927B25 for ; Tue, 18 Jan 2022 10:56:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7557E45204 for ; Tue, 18 Jan 2022 10:56:37 +0100 (CET) Date: Tue, 18 Jan 2022 10:56:26 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Fabian Ebner , pve-devel@lists.proxmox.com References: <20220113100831.34113-1-f.ebner@proxmox.com> <20220113100831.34113-5-f.ebner@proxmox.com> <1642418050.f53h13is6j.astroid@nora.none> <48c3e875-a4fb-a263-c4f2-49c21d6facec@proxmox.com> In-Reply-To: <48c3e875-a4fb-a263-c4f2-49c21d6facec@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1642499280.nrzamq9e8a.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.333 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, nodes.pm] Subject: Re: [pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf endpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 09:56:38 -0000 On January 18, 2022 9:35 am, Fabian Ebner wrote: > Am 17.01.22 um 16:38 schrieb Fabian Gr=C3=BCnbichler: >> missing a reason why this is added to the generic node index, and not >> somewhere under qemu? >> >=20 > I suppose because having it under /nodes/{node}/qemu/ would imply having=20 > it under /nodes/{node}/qemu/{vmid}/ (as we don't support having both=20 > path/{regex} and path/static at the same time), but it doesn't depend on=20 > any vmid? ack, that makes sense, and now that you mention it I remember having=20 this exact discussion back when the CPU model stuff was introduced ;) >=20 >=20 >> On January 13, 2022 11:08 am, Fabian Ebner wrote: >>> Signed-off-by: Dominic J=C3=A4ger >>> [split into its own patch + add to index] >>> Signed-off-by: Fabian Ebner >>> --- >>> >>> Needs dependency bump for qemu-server. >>> >>> Changes from v9: >>> * Add entry to /node/'s index. >>> >>> PVE/API2/Nodes.pm | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm >>> index d57a1937..5f6208d5 100644 >>> --- a/PVE/API2/Nodes.pm >>> +++ b/PVE/API2/Nodes.pm >>> @@ -49,6 +49,7 @@ use PVE::API2::LXC; >>> use PVE::API2::Network; >>> use PVE::API2::NodeConfig; >>> use PVE::API2::Qemu::CPU; >>> +use PVE::API2::Qemu::OVF; >>> use PVE::API2::Qemu; >>> use PVE::API2::Replication; >>> use PVE::API2::Services; >>> @@ -71,6 +72,11 @@ __PACKAGE__->register_method ({ >>> path =3D> 'qemu', >>> }); >>> =20 >>> +__PACKAGE__->register_method ({ >>> + subclass =3D> "PVE::API2::Qemu::OVF", >>> + path =3D> 'readovf', >>> +}); >>> + >>> __PACKAGE__->register_method ({ >>> subclass =3D> "PVE::API2::LXC", >>> path =3D> 'lxc', >>> @@ -233,6 +239,7 @@ __PACKAGE__->register_method ({ >>> { name =3D> 'network' }, >>> { name =3D> 'qemu' }, >>> { name =3D> 'query-url-metadata' }, >>> + { name =3D> 'readovf' }, >>> { name =3D> 'replication' }, >>> { name =3D> 'report' }, >>> { name =3D> 'rrd' }, # fixme: remove? >>> --=20 >>> 2.30.2 >>> >>> >>> >>> _______________________________________________ >>> pve-devel mailing list >>> pve-devel@lists.proxmox.com >>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >>> >>=20 >>=20 >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20