From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id C6785708B3 for ; Fri, 14 May 2021 11:23:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id B1BA415474 for ; Fri, 14 May 2021 11:23:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 38A6F15465 for ; Fri, 14 May 2021 11:23:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 0CA6A42D96; Fri, 14 May 2021 11:23:12 +0200 (CEST) Message-ID: <1641336a-d7a5-4336-96bd-8731fb8edc00@proxmox.com> Date: Fri, 14 May 2021 11:23:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210512082240.36224-1-l.stechauner@proxmox.com> From: Dominik Csapak In-Reply-To: <20210512082240.36224-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [status.pm, tools.pm, nodes.pm, storage.pm] Subject: Re: [pve-devel] [PATCH-SERIES v5 manager/common/storage] fix #1710: add download from url button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 09:23:42 -0000 api side LGTM and it works like advertised, some coding issues on the last patch, i'll answer there separately On 5/12/21 10:22, Lorenz Stechauner wrote: > changes to v4: > reworked check_file_hash > small fixes: typos, default values, etc. > > patches: > 1 - manager: add query_url_metadata method > 2 - common: add download_file_from_url > 3 - manager: refactor aplinfo to use common download function > 4 - storage: add download_url method > 5 - manager: add HashAlgorithmSelector > 6 - manager: change download task format > 7 - manager: fix #1710: add download from url button > > > pve-manager: > Lorenz Stechauner (5): > api: nodes: add query_url_metadata method > api: nodes: refactor aplinfo to use common download function > ui: add HashAlgorithmSelector > ui: Utils: change download task format > fix #1710: ui: storage: add download from url button > > PVE/API2/Nodes.pm | 159 +++++++----- > www/manager6/Makefile | 1 + > www/manager6/Utils.js | 2 +- > www/manager6/form/HashAlgorithmSelector.js | 16 ++ > www/manager6/storage/Browser.js | 8 + > www/manager6/storage/ContentView.js | 282 +++++++++++++++++++-- > 6 files changed, 376 insertions(+), 92 deletions(-) > create mode 100644 www/manager6/form/HashAlgorithmSelector.js > > > pve-common: > Lorenz Stechauner (1): > tools: add download_file_from_url > > src/PVE/Tools.pm | 124 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 124 insertions(+) > > > pve-storage > Lorenz Stechauner (1): > status: add download_url method > > PVE/API2/Storage/Status.pm | 118 +++++++++++++++++++++++++++++++++++-- > PVE/Storage.pm | 10 ++++ > 2 files changed, 123 insertions(+), 5 deletions(-) >