From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ABB4283374 for ; Fri, 3 Dec 2021 10:20:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8AECC22660 for ; Fri, 3 Dec 2021 10:20:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BB6FD22652 for ; Fri, 3 Dec 2021 10:20:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8842A446F5 for ; Fri, 3 Dec 2021 10:20:21 +0100 (CET) Date: Fri, 03 Dec 2021 10:20:14 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Oguz Bektas , Proxmox VE development discussion References: <20211202133842.1000372-1-o.bektas@proxmox.com> <6670482a-986b-d81d-bde1-96d0c8de48ee@proxmox.com> In-Reply-To: <6670482a-986b-d81d-bde1-96d0c8de48ee@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1638523162.slpbukq1bk.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.253 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH common] fix #3747: download_file_from_url: trim whitespace before comparing checksum X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 09:20:53 -0000 On December 3, 2021 9:03 am, Fabian Ebner wrote: > Am 02.12.21 um 14:38 schrieb Oguz Bektas: >> so that we don't get checksum mismatch in case the user accidentally >> copies whitespace in the checksum field. >>=20 >=20 > Isn't this better done in the UI? Or at least upon parameter validation=20 > (but we don't do this for any other parameter, or)?. >=20 >> Signed-off-by: Oguz Bektas >> --- >> src/PVE/Tools.pm | 1 + >> 1 file changed, 1 insertion(+) >>=20 >> diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm >> index 787942a..fa14f2f 100644 >> --- a/src/PVE/Tools.pm >> +++ b/src/PVE/Tools.pm >> @@ -1921,6 +1921,7 @@ sub download_file_from_url { >> if (defined($opts->{"${_}sum"})) { >> $checksum_algorithm =3D $_; >> $checksum_expected =3D $opts->{"${_}sum"}; >> + $checksum_expected =3D~ s/^\s+|\s+$//g; PVE::Tools::trim ? >> last; >> } >> } >>=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20