From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8BA437E940 for ; Thu, 11 Nov 2021 10:10:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78989276A1 for ; Thu, 11 Nov 2021 10:09:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 897AD27696 for ; Thu, 11 Nov 2021 10:09:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5893240A97 for ; Thu, 11 Nov 2021 10:09:51 +0100 (CET) Date: Thu, 11 Nov 2021 10:09:45 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20211110170013.1692360-1-a.lauterer@proxmox.com> In-Reply-To: <20211110170013.1692360-1-a.lauterer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1636621768.bzbvwi68si.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.283 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] disk reassign: add unused disks directly to config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 09:10:22 -0000 On November 10, 2021 6:00 pm, Aaron Lauterer wrote: > Using $update_vm_api for unused disks will cause them to end up as a > pending change if the VM is running. >=20 > Signed-off-by: Aaron Lauterer > --- > That case is already handled for containers but was missed for VMs. >=20 > PVE/API2/Qemu.pm | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) >=20 > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 4404da9..24b1d2f 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -3607,15 +3607,21 @@ __PACKAGE__->register_method({ > PVE::QemuConfig->write_config($vmid, $source_conf); > =20 > my $drive_string =3D PVE::QemuServer::print_drive($drive); > - &$update_vm_api( > - { > - node =3D> $node, > - vmid =3D> $target_vmid, > - digest =3D> $target_digest, > - $target_disk =3D> $drive_string, > - }, > - 1, > - ); > + > + if ($target_disk =3D~ /^unused\d+$/) { > + $target_conf->{$target_disk} =3D $drive_string; > + PVE::QemuConfig->write_config($target_vmid, $target_conf); > + } else { > + &$update_vm_api( > + { > + node =3D> $node, > + vmid =3D> $target_vmid, > + digest =3D> $target_digest, > + $target_disk =3D> $drive_string, > + }, > + 1, > + ); > + } > =20 > # remove possible replication snapshots > if (PVE::Storage::volume_has_feature( > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20