From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 022187DE57 for ; Tue, 9 Nov 2021 17:50:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F40DF10FAB for ; Tue, 9 Nov 2021 17:50:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3A6E710FA0 for ; Tue, 9 Nov 2021 17:50:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1164B45E4D for ; Tue, 9 Nov 2021 17:50:35 +0100 (CET) Date: Tue, 09 Nov 2021 17:50:26 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20211019075459.14328-1-f.ebner@proxmox.com> In-Reply-To: <20211019075459.14328-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1636476615.n4qqofuzk3.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.289 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replicationtestenv.pm, storage.pm, plugin.pm, zfsplugin.pm, replication.pm, proxmox.com, abstractconfig.pm, zfspoolplugin.pm] Subject: [pve-devel] applied-series: [PATCH-SERIES storage/guest-common/manager] Follow-up for fixing replication/rollback interaction X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 16:50:36 -0000 On October 19, 2021 9:54 am, Fabian Ebner wrote: > Returning more information about snapshots allows for better decisions > when picking the incremental base snapshot. Namely, to distinguish > between different snapshots with the same name, and to choose a more > recent snapshot in some cases, reducing the send delta. On top of > that, the code in find_common_replication_snapshot becomes simpler. >=20 > Mostly as discussed off-list with Fabian G., but instead of just > changing the return type of volume_snapshot_list, it has been replaced > with a new function. I felt like that would allow for a cleaner break > and the old name was not fully accurate anymore. >=20 >=20 > Applies on top of the original series: > https://lists.proxmox.com/pipermail/pve-devel/2021-August/049699.html >=20 >=20 > Dependencies/breaks: > 1. pve-guest-common (except patch #1) depends on pve-storage patch #1. > 2. pve-storage patch #2 breaks old pve-guest-common. > 3. pve-guest-common patch #2 build-breaks old pve-manager. > 4. pve-manager patch #3 build-depends on pve-guest-common patch #2. >=20 >=20 > pve-storage: >=20 > Fabian Ebner (3): > plugin: add volume_snapshot_info function > plugin: remove volume_snapshot_list > bump APIVER and APIAGE >=20 > ApiChangeLog | 16 ++++++++++++++++ > PVE/Storage.pm | 21 +++++++-------------- > PVE/Storage/Plugin.pm | 11 ++++++----- > PVE/Storage/ZFSPlugin.pm | 6 ------ > PVE/Storage/ZFSPoolPlugin.pm | 23 ++++++++++++++++++----- > 5 files changed, 47 insertions(+), 30 deletions(-) >=20 >=20 > pve-guest-common: >=20 > Fabian Ebner (4): > replication: refactor finding most recent common replication snapshot > replication: prepare: return additional information about snapshots > replication: find common snapshot: use additional information > config: snapshot delete check: use volume_snapshot_info >=20 > src/PVE/AbstractConfig.pm | 4 +-- > src/PVE/Replication.pm | 73 ++++++++++++++++++--------------------- > 2 files changed, 36 insertions(+), 41 deletions(-) >=20 >=20 > pve-manager: >=20 > Fabian Ebner (3): > test: replication: avoid implicit return for volume_snapshot > test: replication: mock volume_snapshot_info > test: replication: remove mocking for obsolete volume_snapshot_list >=20 > test/ReplicationTestEnv.pm | 40 +++++++++++++++++++++++--------------- > 1 file changed, 24 insertions(+), 16 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20