From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0D0FF7DE52 for ; Tue, 9 Nov 2021 17:50:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF5B110F20 for ; Tue, 9 Nov 2021 17:49:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B910F10F15 for ; Tue, 9 Nov 2021 17:49:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 86D8E45DA6 for ; Tue, 9 Nov 2021 17:49:31 +0100 (CET) Date: Tue, 09 Nov 2021 17:49:23 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210812110111.73883-1-f.ebner@proxmox.com> In-Reply-To: <20210812110111.73883-1-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1636476549.jks9vj5ga1.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [btrfsplugin.pm, replicationconfig.pm, storage.pm, plugin.pm, replication.pm, abstractconfig.pm, zfspoolplugin.pm, proxmox.com, config.pm, qemuconfig.pm] URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: [pve-devel] applied-series: [PATCH-SERIES v3] fix #3111: fix interaction of snapshot operations with replication X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 16:50:03 -0000 On August 12, 2021 1:00 pm, Fabian Ebner wrote: > For more context, see also: > https://lists.proxmox.com/pipermail/pve-devel/2021-August/049694.html >=20 > Changes from v2: > * Many new patches, as the approach is different: > For one, only replication snapshots that are blocking rollback > are removed. Second, consider more snapshot candidates when > probing for an incremental replication base. Last, instead of > directly running replication after rollback, prevent snapshot > deletion if it might be the current incremental replication > base. >=20 > Many thanks to Fabian G. for discussing those ideas with me! >=20 > All patches are new in v3, except guest-common patch #1, which > hasn't changed much, and would fix some issues already by itself. >=20 > I think nothing requires an explicit dependency bump, but some things, > like "remove only the real blockers", will only start working when all > the pieces are in place. >=20 >=20 > storage: >=20 > Fabian Ebner (3): > zfspool: add zfs_get_sorted_snapshot_list helper > zfspool: add blockers parameter to volume_snapshot_is_possible > test: zfspool: extend some rollback is possible tests with new > blockers parameter >=20 > PVE/Storage.pm | 4 +-- > PVE/Storage/BTRFSPlugin.pm | 2 +- > PVE/Storage/Plugin.pm | 5 ++- > PVE/Storage/ZFSPoolPlugin.pm | 65 +++++++++++++++------------------- > test/run_test_zfspoolplugin.pl | 65 +++++++++++++++++++++++++--------- > 5 files changed, 85 insertions(+), 56 deletions(-) >=20 >=20 > container: >=20 > Fabian Ebner (1): > config: rollback is possible: add blockers parameter >=20 > src/PVE/LXC/Config.pm | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 >=20 > qemu-server: >=20 > Fabian Ebner (1): > config: rollback is possible: add blockers parameter >=20 > PVE/QemuConfig.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 >=20 > guest-common: >=20 > Fabian Ebner (7): > partially fix #3111: snapshot rollback: improve removing replication > snapshots > config: rollback: factor out helper for removing replication snapshots > partially fix #3111: further improve removing replication snapshots > replication: remove unused variable and style fixes > replication: pass guest config to find_common_replication_snapshot > partially fix #3111: replication: be less picky when selecting > incremental base > fix #3111 config: snapshot delete: check if replication still needs it >=20 > src/PVE/AbstractConfig.pm | 120 +++++++++++++++++++++++++++++++---- > src/PVE/Replication.pm | 66 ++++++++++++++++---- > src/PVE/ReplicationConfig.pm | 14 +++++ > 3 files changed, 177 insertions(+), 23 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20