From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6EE1071B7B for ; Tue, 5 Oct 2021 13:12:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CC4627358 for ; Tue, 5 Oct 2021 13:12:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CA3C22734A for ; Tue, 5 Oct 2021 13:12:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9B4CA455B1 for ; Tue, 5 Oct 2021 13:12:14 +0200 (CEST) Date: Tue, 05 Oct 2021 13:12:02 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20211005094602.1974632-1-aderumier@odiso.com> In-Reply-To: <20211005094602.1974632-1-aderumier@odiso.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1633432128.w00qu8ioxe.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.346 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 qemu-server] qemu-agent: allow hotplug of fstrim_cloned_disk option. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 11:12:46 -0000 On October 5, 2021 11:46 am, Alexandre Derumier wrote: > This option don't have any impact on device itself. >=20 > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 076ce59..907d522 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -4829,6 +4829,8 @@ sub vmconfig_hotplug_pending { > } elsif ($opt eq 'cpulimit') { > my $cpulimit =3D $conf->{pending}->{$opt} =3D=3D 0 ? -1 : int($conf->{= pending}->{$opt} * 100000); > $cgroup->change_cpu_quota($cpulimit, 100000); > + } elsif ($opt eq 'agent') { > + vmconfig_update_agent($conf, $opt, $value); > } else { > die "skip\n"; # skip non-hot-pluggable options > } > @@ -4988,6 +4990,23 @@ sub vmconfig_update_net { > } > } > =20 > +sub vmconfig_update_agent { > + my ($conf, $opt, $value) =3D @_; > + > + if ($conf->{$opt} && (my $old_agent =3D parse_guest_agent($conf))) { > + > + my $agent =3D parse_guest_agent({$opt =3D> $value}); > + > + # skip non hotpluggable value shouldn't this be the other way round? check keys which are different,=20 and have a list of hotpluggable ones, skip if any others are different? that way if we add another property to the agent it's fail-safe=20 (defaults to not being hotpluggable) until it is added to the explicit=20 list. > + if (safe_string_ne($agent->{enabled}, $old_agent->{enabled}) || > + safe_string_ne($agent->{type}, $old_agent->{type})) { > + die "skip\n"; > + } > + } else { > + die "skip\n"; > + } > +} > + > sub vmconfig_update_disk { > my ($storecfg, $conf, $hotplug, $vmid, $opt, $value, $arch, $machine= _type) =3D @_; > =20 > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20