From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3006A68B0E for ; Fri, 10 Sep 2021 12:03:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E0D6127D2 for ; Fri, 10 Sep 2021 12:03:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7CBB7127C7 for ; Fri, 10 Sep 2021 12:03:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 553794466E for ; Fri, 10 Sep 2021 12:03:47 +0200 (CEST) Date: Fri, 10 Sep 2021 12:03:40 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Fabian Ebner , pve-devel@lists.proxmox.com References: <20210910074820.1477562-1-f.gruenbichler@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1631268198.97pwtciia3.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.408 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemu.pm] Subject: Re: [pve-devel] [PATCH qemu-server 1/2] api: return UPID in template call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 10:03:48 -0000 On September 10, 2021 10:32 am, Fabian Ebner wrote: > The same issues are present for the corresponding API call in=20 > pve-container ;) thanks, should have checked there myself. will send a patch for that as=20 well. > Both patches > Reviewed-by: Fabian Ebner >=20 > Am 10.09.21 um 09:48 schrieb Fabian Gr=C3=BCnbichler: >> as reported on the forum, this is currently missing, making status >> queries via the API impossible: >>=20 >> https://forum.proxmox.com/threads/create-vm-via-api-interface.95942/#pos= t-416084 >>=20 >> Signed-off-by: Fabian Gr=C3=BCnbichler >> --- >> PVE/API2/Qemu.pm | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >>=20 >> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm >> index ef0d877..0a23525 100644 >> --- a/PVE/API2/Qemu.pm >> +++ b/PVE/API2/Qemu.pm >> @@ -4336,7 +4336,10 @@ __PACKAGE__->register_method({ >> =20 >> }, >> }, >> - returns =3D> { type =3D> 'null'}, >> + returns =3D> { >> + type =3D> 'string', >> + description =3D> "the task ID.", >> + }, >> code =3D> sub { >> my ($param) =3D @_; >> =20 >> @@ -4375,8 +4378,7 @@ __PACKAGE__->register_method({ >> return $rpcenv->fork_worker('qmtemplate', $vmid, $authuser, $real= cmd); >> }; >> =20 >> - PVE::QemuConfig->lock_config($vmid, $updatefn); >> - return; >> + return PVE::QemuConfig->lock_config($vmid, $updatefn); >> }}); >> =20 >> __PACKAGE__->register_method({ >>=20 >=20