From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 43DFB752AD for ; Wed, 23 Jun 2021 15:51:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39454BE47 for ; Wed, 23 Jun 2021 15:51:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6ADCDBE3B for ; Wed, 23 Jun 2021 15:51:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 39C594661A for ; Wed, 23 Jun 2021 15:51:38 +0200 (CEST) Date: Wed, 23 Jun 2021 15:51:29 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion Cc: Wolfgang Bumiller References: <20210622121828.84178-1-w.bumiller@proxmox.com> <20210622121828.84178-9-w.bumiller@proxmox.com> In-Reply-To: <20210622121828.84178-9-w.bumiller@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1624456103.ixh6z6wfc6.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.645 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 container 3/3] special case btrfs+quotas to use subvolumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2021 13:51:40 -0000 On June 22, 2021 2:18 pm, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > New in v2. >=20 > src/PVE/LXC.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 0a8a532..fc06842 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1893,7 +1893,7 @@ sub alloc_disk { > eval { > my $do_format =3D 0; > if ($scfg->{content}->{rootdir} && $scfg->{path}) { > - if ($size_kb > 0) { > + if ($size_kb > 0 && !($scfg->{type} eq 'btrfs' && $scfg->{quotas}))= { this is actually not enough.. btrfs with quotas now creates subvols with=20 size 0 (=3D=3D no quota), and then everything fails because the storage=20 plugin expects a quota to be there but there is none. even with that=20 fixed up, at least resize_disk is still broken: $ pct resize 123 mp0 +1G btrfs error: ERROR: invalid qgroupid or subvolume path: 0/0/286 the actual qgroupid should be 0/286.. > $volid =3D PVE::Storage::vdisk_alloc($storecfg, $storage, $vmid, 'raw'= , undef, $size_kb); > $do_format =3D 1; > } else { > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20