From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F305E7303A for ; Thu, 17 Jun 2021 14:33:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E63F51B6A5 for ; Thu, 17 Jun 2021 14:33:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 61FB81B69A for ; Thu, 17 Jun 2021 14:33:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2FF0B441A9; Thu, 17 Jun 2021 14:33:36 +0200 (CEST) Date: Thu, 17 Jun 2021 14:33:29 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Denis Knauf , Proxmox VE development discussion References: <20210616182317.12758-1-deac+git@denkn.at> <20210616182317.12758-2-deac+git@denkn.at> <92168992-a4f5-76ee-c4f1-66a7e837a303@proxmox.com> In-Reply-To: <92168992-a4f5-76ee-c4f1-66a7e837a303@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1623933097.d1qp4xibda.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.811 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 container 2/2] close #3471: Support for NetworkManager on CentOS. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 12:33:37 -0000 On June 17, 2021 2:28 pm, Dominik Csapak wrote: > hi, >=20 > did not took a look at the whole patch, but > some things stood out, comments inline >=20 > On 6/16/21 20:23, Denis Knauf wrote: >> NetworkManager is used on RHEL8 and similar distributions like CentOS8, >> AlmaLinux8 and RockyLinux8. >> On RHEL7/CentOS7 it was not mandatory, but possible to use >> NetworkManager. >> The past config was used on CentOS6/7 withour NetworkManager, so tests >> were also testing this basic network-config. >>=20 >> The patches is compatible to any RHEL7/RHEL8-compatible distribution wit= h/without >> NetworkManager. >>=20 >> Because the NetworkManager requires a UUID, the tests were extended by >> special behaviour in case of UUIDs in `ifcfg-eth*`. >>=20 >> Successfully tested against: >> * CentOS7 without NetworkManager >> * CentOS7 with NetworkManager >> * CentOS8 >> * RockyLinux 8 >>=20 >> Signed-off-by: Denis Knauf ... >=20 >> my $data =3D ''; >> my $bootproto =3D ''; >> =20 >> @@ -213,7 +214,7 @@ sub setup_network { >> if ($d->{ip6} eq 'auto') { >> $data .=3D "IPV6_AUTOCONF=3Dyes\n"; >> } >> - if ($d->{ip6} eq 'dhcp') { >> + elsif ($d->{ip6} eq 'dhcp') { >=20 > this change does nothing? it changes the condition for the else branch below (previously, ip6 =3D=3D=20 auto would take it, now it does not - see the bug report). >=20 >> $data .=3D "DHCPV6C=3Dyes\n"; >> } else { >> $data .=3D "IPV6ADDR=3D$d->{ip6}\n"; >> @@ -229,6 +230,15 @@ sub setup_network { >> } >> }