From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6DAC371462 for ; Thu, 10 Jun 2021 14:36:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5ECCC2F6DA for ; Thu, 10 Jun 2021 14:35:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B31872F6CC for ; Thu, 10 Jun 2021 14:35:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 894FC46756 for ; Thu, 10 Jun 2021 14:35:37 +0200 (CEST) Date: Thu, 10 Jun 2021 14:35:30 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210609131852.167416-1-w.bumiller@proxmox.com> <20210609131852.167416-9-w.bumiller@proxmox.com> In-Reply-To: <20210609131852.167416-9-w.bumiller@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1623328402.jo4fj3v9o7.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.885 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemumigrate.pm] Subject: Re: [pve-devel] [PATCH qemu-server] allow migrating raw btrfs volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 12:36:09 -0000 On June 9, 2021 3:18 pm, Wolfgang Bumiller wrote: > Signed-off-by: Wolfgang Bumiller > --- > PVE/QemuMigrate.pm | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 6375a15..5b07c20 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -502,7 +502,10 @@ sub scan_local_volumes { > # exceptions: 'zfspool' or 'qcow2' files (on directory storage) > =20 > die "online storage migration not possible if snapshot exists\n" if $s= elf->{running}; > - if (!($scfg->{type} eq 'zfspool' || $local_volumes->{$volid}->{format}= eq 'qcow2')) { > + if (!($scfg->{type} eq 'zfspool' > + || ($scfg->{type} eq 'btrfs' && $local_volumes->{$volid}->{format}= eq 'raw') > + || $local_volumes->{$volid}->{format} eq 'qcow2' > + )) { > die "non-migratable snapshot exists\n"; > } > } > @@ -553,7 +556,7 @@ sub scan_local_volumes { > my ($sid, $volname) =3D PVE::Storage::parse_volume_id($volid); > my $scfg =3D PVE::Storage::storage_config($storecfg, $sid); > =20 > - my $migratable =3D $scfg->{type} =3D~ /^(?:dir|zfspool|lvmthin|lvm)= $/; > + my $migratable =3D $scfg->{type} =3D~ /^(?:dir|btrfs|zfspool|lvmthi= n|lvm)$/; also stumbled upon this when doing the remote migrate stuff - AFAICT,=20 this is basically a leftover thing from when migration was more limited.=20 atm this is basically every built-in storage type that is not shared=20 (and for remote migration, we'd add most shared storage types as well). I'd either drop it altogether, or move it to the storage plugin=20 definition (possible two booleans - one for NBD-based qemu migration,=20 one for storage migration?). > =20 > die "can't migrate '$volid' - storage type '$scfg->{type}' not supp= orted\n" > if !$migratable; > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20