From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 45A7970B98 for ; Tue, 8 Jun 2021 15:04:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3633E1AEBF for ; Tue, 8 Jun 2021 15:04:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3ABE51AEB3 for ; Tue, 8 Jun 2021 15:04:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0AD6043E49 for ; Tue, 8 Jun 2021 15:04:08 +0200 (CEST) Date: Tue, 08 Jun 2021 15:04:00 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210604134946.152720-1-f.ebner@proxmox.com> <20210604134946.152720-9-f.ebner@proxmox.com> In-Reply-To: <20210604134946.152720-9-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1623157330.74f1vq87w2.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.925 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH storage 2/3] update reminder to remove maxfiles X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 13:04:39 -0000 On June 4, 2021 3:49 pm, Fabian Ebner wrote: > Remove it later, once it's been deprecated for a while. shouldn't we start warning that it is deprecated? or at least add a=20 deprecation notice to the parameter description? >=20 > Signed-off-by: Fabian Ebner > --- > PVE/Storage.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index aa36bad..0b3671a 100755 > --- a/PVE/Storage.pm > +++ b/PVE/Storage.pm > @@ -125,7 +125,7 @@ sub lock_storage_config { > } > } > =20 > -# FIXME remove maxfiles for PVE 7.0 > +# FIXME remove maxfiles for PVE 8.0 or PVE 9.0 > my $convert_maxfiles_to_prune_backups =3D sub { > my ($scfg) =3D @_; > =20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20