From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C19078749 for ; Fri, 30 Apr 2021 13:27:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F3EA276CA for ; Fri, 30 Apr 2021 13:27:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BEFBF276BE for ; Fri, 30 Apr 2021 13:27:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9114942998 for ; Fri, 30 Apr 2021 13:27:49 +0200 (CEST) Date: Fri, 30 Apr 2021 13:27:42 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210429094812.51587-1-l.stechauner@proxmox.com> <20210429094853.51768-1-l.stechauner@proxmox.com> In-Reply-To: <20210429094853.51768-1-l.stechauner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1619781642.v0a91lmmox.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, accesscontrol.pm] Subject: Re: [pve-devel] [PATCH access-control 1/1] fix #3402: add Pool.Audit permission X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2021 11:27:50 -0000 On April 29, 2021 11:48 am, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > PVE/AccessControl.pm | 8 ++++++-- > README | 1 + > 2 files changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm > index f7d4e78..888875e 100644 > --- a/PVE/AccessControl.pm > +++ b/PVE/AccessControl.pm > @@ -819,8 +819,12 @@ my $privgroups =3D { > admin =3D> [ > 'Pool.Allocate', # create/delete pools > ], > - user =3D> [], > - audit =3D> [], > + user =3D> [ > + 'Pool.Audit', > + ], this hunk actually causes a new built-in "PVEUser" role to be defined.. I am not sure whether it's worth it (probably PVEAuditor already serves=20 that niche for almost all use-cases). but if we include it, then this=20 requires a pve-docs patch as well ;) users might also already have a=20 custom role named like that, so potentially defer to 7.0 as breaking=20 change? > + audit =3D> [ > + 'Pool.Audit', > + ], > }, > }; > =20 > diff --git a/README b/README > index 33643a6..698b7a8 100644 > --- a/README > +++ b/README > @@ -96,6 +96,7 @@ privileges: > VM.Config.Options: modify any other VM configuration=20 > =20 > Pool.Allocate: create/remove/modify a pool. > + Pool.Audit: view/browse pool > =20 > Datastore.Allocate: create/remove/modify a data store. > Datastore.AllocateSpace: allocate space on a datastore > --=20 > 2.20.1 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =