From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 46C057593B for ; Thu, 22 Apr 2021 10:42:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 33F49192D8 for ; Thu, 22 Apr 2021 10:42:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 71BEF192AD for ; Thu, 22 Apr 2021 10:42:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3E633425E5 for ; Thu, 22 Apr 2021 10:42:23 +0200 (CEST) Date: Thu, 22 Apr 2021 10:42:15 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210420131437.25039-1-d.whyte@proxmox.com> In-Reply-To: <20210420131437.25039-1-d.whyte@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1619080870.b4j72slfn6.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v2 qemu-server] fix #3369: auto-start vm after failed stopmode backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 08:42:54 -0000 On April 20, 2021 3:14 pm, Dylan Whyte wrote: > Fixes an issue in which a VM/CT fails to automatically restart after a > failed stop-mode backup. >=20 > Also fixes a minor typo in a comment >=20 > Signed-off-by: Dylan Whyte Reviewed-by: Fabian Gr=C3=BCnbichler > --- >=20 > Note: >=20 > v1->v2: > - Fix the issue from within PVE::VZDump::QemuServer, rather than adding > tedious sleep call and state checking in PVE::VZDump. >=20 > PVE/VZDump/QemuServer.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm > index 8920ac1f..42a60fc7 100644 > --- a/PVE/VZDump/QemuServer.pm > +++ b/PVE/VZDump/QemuServer.pm > @@ -551,6 +551,7 @@ sub archive_pbs { > if ($err) { > $self->logerr($err); > $self->mon_backup_cancel($vmid); > + $self->resume_vm_after_job_start($task, $vmid); > } > $self->restore_vm_power_state($vmid); > =20 > @@ -729,6 +730,7 @@ sub archive_vma { > if ($err) { > $self->logerr($err); > $self->mon_backup_cancel($vmid); > + $self->resume_vm_after_job_start($task, $vmid); > } > =20 > $self->restore_vm_power_state($vmid); > @@ -815,7 +817,7 @@ sub enforce_vm_running_for_backup { > die $@ if $@; > } > =20 > -# resume VM againe once we got in a clear state (stop mode backup of run= ning VM) > +# resume VM again once in a clear state (stop mode backup of running VM) > sub resume_vm_after_job_start { > my ($self, $task, $vmid) =3D @_; > =20 > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =