From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ADCD26CD22 for ; Wed, 31 Mar 2021 11:34:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A4D8ECF91 for ; Wed, 31 Mar 2021 11:34:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DECF6CF87 for ; Wed, 31 Mar 2021 11:34:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AEF2742949 for ; Wed, 31 Mar 2021 11:34:44 +0200 (CEST) Date: Wed, 31 Mar 2021 11:34:36 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20201215124840.29914-1-a.lauterer@proxmox.com> <20201215124840.29914-2-a.lauterer@proxmox.com> In-Reply-To: <20201215124840.29914-2-a.lauterer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1617182685.l2t08rgixe.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, glusterfsplugin.pm, plugins.pm, zfspoolplugin.pm, lvmplugin.pm, storage.pm, gnu.org, cifsplugin.pm, rbdplugin.pm, basedirplugin.pm, dirplugin.pm, lvmthinplugin.pm, plugin.pm, nfsplugin.pm] Subject: Re: [pve-devel] [PATCH v5 storage 1/5] add disk reassign feature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2021 09:34:46 -0000 maybe I am missing something, but AFAICT the volume_has_feature check=20 for the dir based plugins could also be moved to Plugin.pm, since it is=20 always identical: > +sub volume_has_feature { > + my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > + > + my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = =3D > + $class->parse_volname($volname); > + > + if ($feature eq 'reassign') { > + return 1 if !$isBase && $format =3D~ /^raw$|^qcow2$|^vmdk$/; > + return undef; > + } else { > + return $class->SUPER::volume_has_feature($scfg, $feature, $storeid, $vo= lname, $snapname, $running, $opts); > + } > +} could then become sub volume_has_feature { my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running, $= opts) =3D @_; return $class->file_can_reassign_volume(@_) if $feature eq 'reassign'; return $class->SUPER::volume_has_feature(@_); } with file_can_reassign_volume calling parse_volname (which is shared for=20 all dir based plugins!). I guess theoretically we could also support renaming subvols (it's just=20 a dir rename?), but it's a pretty legacy usecase anyway so we can not=20 include it until someone complains. On December 15, 2020 1:48 pm, Aaron Lauterer wrote: > Functionality has been added for the following storage types: >=20 > * dir based ones > * directory > * NFS > * CIFS > * gluster > * ZFS > * (thin) LVM > * Ceph >=20 > A new feature `reassign` has been introduced to mark which storage > plugin supports the feature. >=20 > Version API and AGE have been bumped. >=20 > Signed-off-by: Aaron Lauterer > --- > v4 -> v5: > * rebased on master > * bumped api ver and api age > * rephrased "not implemented" message as suggested [0]. >=20 > v3 -> v4: > * revert intermediate storage plugin for directory based plugins > * add a `die "not supported"` method in Plugin.pm > * dir based plugins now call the file_reassign_volume method in > Plugin.pm as the generic file/directory based method > * restored old `volume_has_feature` method in Plugin.pm and override it > in directory based plugins to check against the new `reassign` feature > (not too happy about the repetition for each plugin) >=20 > v2 -> v3: > * added feature flags instead of dummy "not implemented" methods in > plugins which do not support it as that would break compatibility with > 3rd party plugins. > Had to make $features available outside the `has_features` method in > Plugins.pm in order to be able to individually add features in the > `BaseDirPlugin.pm`. > * added the BaseDirPlugin.pm to maintain compat with 3rd party plugins, > this is explained in the commit message > * moved the actual renaming from the `reassign_volume` to a dedicated > `rename_volume` method to make this functionality available to other > possible uses in the future. > * added support for linked clones ($base) >=20 >=20 > rfc -> v1 -> v2: nothing changed >=20 > [0] https://lists.proxmox.com/pipermail/pve-devel/2020-November/046031.ht= ml >=20 > PVE/Storage.pm | 15 ++++++++-- > PVE/Storage/CIFSPlugin.pm | 19 +++++++++++++ > PVE/Storage/DirPlugin.pm | 19 +++++++++++++ > PVE/Storage/GlusterfsPlugin.pm | 19 +++++++++++++ > PVE/Storage/LVMPlugin.pm | 24 ++++++++++++++++ > PVE/Storage/LvmThinPlugin.pm | 1 + > PVE/Storage/NFSPlugin.pm | 19 +++++++++++++ > PVE/Storage/Plugin.pm | 51 ++++++++++++++++++++++++++++++++++ > PVE/Storage/RBDPlugin.pm | 31 +++++++++++++++++++++ > PVE/Storage/ZFSPoolPlugin.pm | 26 +++++++++++++++++ > 10 files changed, 222 insertions(+), 2 deletions(-) >=20 > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index aded60e..ca3b7bd 100755 > --- a/PVE/Storage.pm > +++ b/PVE/Storage.pm > @@ -41,11 +41,11 @@ use PVE::Storage::DRBDPlugin; > use PVE::Storage::PBSPlugin; > =20 > # Storage API version. Increment it on changes in storage API interface. > -use constant APIVER =3D> 8; > +use constant APIVER =3D> 9; > # Age is the number of versions we're backward compatible with. > # This is like having 'current=3DAPIVER' and age=3D'APIAGE' in libtool, > # see https://www.gnu.org/software/libtool/manual/html_node/Libtool-vers= ioning.html > -use constant APIAGE =3D> 7; > +use constant APIAGE =3D> 8; > =20 > # load standard plugins > PVE::Storage::DirPlugin->register(); > @@ -351,6 +351,7 @@ sub volume_snapshot_needs_fsfreeze { > # snapshot - taking a snapshot is possible > # sparseinit - volume is sparsely initialized > # template - conversion to base image is possible > +# reassign - reassigning disks to other guest is possible > # $snap - check if the feature is supported for a given snapshot > # $running - if the guest owning the volume is running > # $opts - hash with further options: > @@ -1843,6 +1844,16 @@ sub complete_volume { > return $res; > } > =20 > +sub reassign_volume { > + my ($cfg, $volid, $target_vmid) =3D @_; > + > + my ($storeid, $volname) =3D parse_volume_id($volid); > + my $scfg =3D storage_config($cfg, $storeid); > + my $plugin =3D PVE::Storage::Plugin->lookup($scfg->{type}); > + > + return $plugin->reassign_volume($scfg, $storeid, $volname, $target_v= mid); > +} > + > # Various io-heavy operations require io/bandwidth limits which can be > # configured on multiple levels: The global defaults in datacenter.cfg, = and > # per-storage overrides. When we want to do a restore from storage A to = storage > diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm > index be06cc7..f2ff5b4 100644 > --- a/PVE/Storage/CIFSPlugin.pm > +++ b/PVE/Storage/CIFSPlugin.pm > @@ -293,4 +293,23 @@ sub update_volume_notes { > PVE::Storage::DirPlugin::update_volume_notes($class, @_); > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + return $class->file_reassign_volume($scfg, $storeid, $volname, $targ= et_vmid); > +} > + > +sub volume_has_feature { > + my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > + > + my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = =3D > + $class->parse_volname($volname); > + > + if ($feature eq 'reassign') { > + return 1 if !$isBase && $format =3D~ /^raw$|^qcow2$|^vmdk$/; > + return undef; > + } else { > + return $class->SUPER::volume_has_feature($scfg, $feature, $storeid, $vo= lname, $snapname, $running, $opts); > + } > +} > + > 1; > diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm > index 2267f11..f4cb4bb 100644 > --- a/PVE/Storage/DirPlugin.pm > +++ b/PVE/Storage/DirPlugin.pm > @@ -156,4 +156,23 @@ sub check_config { > return $opts; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + return $class->file_reassign_volume($scfg, $storeid, $volname, $targ= et_vmid); > +} > + > +sub volume_has_feature { > + my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > + > + my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = =3D > + $class->parse_volname($volname); > + > + if ($feature eq 'reassign') { > + return 1 if !$isBase && $format =3D~ /^raw$|^qcow2$|^vmdk$/; > + return undef; > + } else { > + return $class->SUPER::volume_has_feature($scfg, $feature, $storeid, $vo= lname, $snapname, $running, $opts); > + } > +} > + > 1; > diff --git a/PVE/Storage/GlusterfsPlugin.pm b/PVE/Storage/GlusterfsPlugin= .pm > index 2dd414d..5c9fd78 100644 > --- a/PVE/Storage/GlusterfsPlugin.pm > +++ b/PVE/Storage/GlusterfsPlugin.pm > @@ -348,4 +348,23 @@ sub check_connection { > return defined($server) ? 1 : 0; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + return $class->file_reassign_volume($scfg, $storeid, $volname, $targ= et_vmid); > +} > + > +sub volume_has_feature { > + my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > + > + my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = =3D > + $class->parse_volname($volname); > + > + if ($feature eq 'reassign') { > + return 1 if !$isBase && $format =3D~ /^raw$|^qcow2$|^vmdk$/; > + return undef; > + } else { > + return $class->SUPER::volume_has_feature($scfg, $feature, $storeid, $vo= lname, $snapname, $running, $opts); > + } > +} > + > 1; > diff --git a/PVE/Storage/LVMPlugin.pm b/PVE/Storage/LVMPlugin.pm > index 73e8e48..19898fa 100644 > --- a/PVE/Storage/LVMPlugin.pm > +++ b/PVE/Storage/LVMPlugin.pm > @@ -339,6 +339,13 @@ sub lvcreate { > run_command($cmd, errmsg =3D> "lvcreate '$vg/$name' error"); > } > =20 > +sub lvrename { > + my ($vg, $oldname, $newname) =3D @_; > + > + my $cmd =3D ['/sbin/lvrename', $vg, $oldname, $newname]; > + run_command($cmd, errmsg =3D> "lvrename '${vg}/${oldname}' to '${new= name}' error"); > +} > + > sub alloc_image { > my ($class, $storeid, $scfg, $vmid, $fmt, $name, $size) =3D @_; > =20 > @@ -583,6 +590,7 @@ sub volume_has_feature { > =20 > my $features =3D { > copy =3D> { base =3D> 1, current =3D> 1}, > + reassign =3D> {current =3D> 1}, > }; > =20 > my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =3D > @@ -683,4 +691,20 @@ sub volume_import_write { > input =3D> '<&'.fileno($input_fh)); > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + > + $class->cluster_lock_storage($storeid, $scfg->{shared}, undef, sub { > + my $target_volname =3D $class->find_free_diskname($storeid, $scfg, $tar= get_vmid); > + return $class->rename_volume($scfg, $storeid, $volname, $target_volname= , $target_vmid); > + }); > +} > + > +sub rename_volume { > + my ($class, $scfg, $storeid, $source_volname, $target_volname, $vmid= ) =3D @_; > + > + lvrename($scfg->{vgname}, $source_volname, $target_volname); > + return "${storeid}:${target_volname}"; > +} > + > 1; > diff --git a/PVE/Storage/LvmThinPlugin.pm b/PVE/Storage/LvmThinPlugin.pm > index c9e127c..895af8b 100644 > --- a/PVE/Storage/LvmThinPlugin.pm > +++ b/PVE/Storage/LvmThinPlugin.pm > @@ -355,6 +355,7 @@ sub volume_has_feature { > template =3D> { current =3D> 1}, > copy =3D> { base =3D> 1, current =3D> 1, snap =3D> 1}, > sparseinit =3D> { base =3D> 1, current =3D> 1}, > + reassign =3D> {current =3D> 1}, > }; > =20 > my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =3D > diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm > index e8e27c0..b5a8f75 100644 > --- a/PVE/Storage/NFSPlugin.pm > +++ b/PVE/Storage/NFSPlugin.pm > @@ -180,4 +180,23 @@ sub update_volume_notes { > PVE::Storage::DirPlugin::update_volume_notes($class, @_); > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + return $class->file_reassign_volume($scfg, $storeid, $volname, $targ= et_vmid); > +} > + > +sub volume_has_feature { > + my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > + > + my ($vtype, $name, $vmid, $basename, $basevmid, $isBase, $format) = =3D > + $class->parse_volname($volname); > + > + if ($feature eq 'reassign') { > + return 1 if !$isBase && $format =3D~ /^raw$|^qcow2$|^vmdk$/; > + return undef; > + } else { > + return $class->SUPER::volume_has_feature($scfg, $feature, $storeid, $vo= lname, $snapname, $running, $opts); > + } > +} > + > 1; > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index 57c58a9..aa496e2 100644 > --- a/PVE/Storage/Plugin.pm > +++ b/PVE/Storage/Plugin.pm > @@ -925,6 +925,7 @@ sub storage_can_replicate { > return 0; > } > =20 > + > sub volume_has_feature { > my ($class, $scfg, $feature, $storeid, $volname, $snapname, $running= , $opts) =3D @_; > =20 > @@ -1454,4 +1455,54 @@ sub volume_import_formats { > return (); > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + die "not implemented in storage plugin '$class'\n"; > +} > + > +# general reassignment method for file/directory based storages > +sub file_reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + > + my $base; > + my $base_vmid; > + my $format; > + my $source_vmid; > + > + (undef, $volname, $source_vmid, $base, $base_vmid, undef, $format) = =3D $class->parse_volname($volname); > + > + # parse_volname strips the directory from volname > + my $source_volname =3D "${source_vmid}/${volname}"; > + > + if ($base) { > + $base =3D "${base_vmid}/${base}/"; > + } else { > + $base =3D ''; > + } > + > + $class->cluster_lock_storage($storeid, $scfg->{shared}, undef, sub { > + my $target_volname =3D $class->find_free_diskname($storeid, $scfg, $tar= get_vmid, $format, 1); > + > + return $class->rename_volume($scfg, $storeid, $source_volname, $target_= volname, $target_vmid, $base); > + }); > +} > + > +sub rename_volume { > + my ($class, $scfg, $storeid, $source_volname, $target_volname, $vmid= , $base) =3D @_; > + > + my $basedir =3D $class->get_subdir($scfg, 'images'); > + my $imagedir =3D "${basedir}/${vmid}"; > + > + mkpath $imagedir; > + > + my $old_path =3D "${basedir}/${source_volname}"; > + my $new_path =3D "${imagedir}/${target_volname}"; > + > + rename($old_path, $new_path) || > + die "rename '$old_path' to '$new_path' failed - $!\n"; > + > + return "${storeid}:${base}${vmid}/${target_volname}"; > +} > + > + > 1; > diff --git a/PVE/Storage/RBDPlugin.pm b/PVE/Storage/RBDPlugin.pm > index fab6d57..86a9a0d 100644 > --- a/PVE/Storage/RBDPlugin.pm > +++ b/PVE/Storage/RBDPlugin.pm > @@ -712,6 +712,7 @@ sub volume_has_feature { > template =3D> { current =3D> 1}, > copy =3D> { base =3D> 1, current =3D> 1, snap =3D> 1}, > sparseinit =3D> { base =3D> 1, current =3D> 1}, > + reassign =3D> {current =3D> 1}, > }; > =20 > my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =3D > @@ -728,4 +729,34 @@ sub volume_has_feature { > return undef; > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + > + my $base;; > + (undef, $volname, undef, $base) =3D $class->parse_volname($volname); > + > + if ($base) { > + $base =3D $base . '/'; > + } else { > + $base =3D ''; > + } > + > + $class->cluster_lock_storage($storeid, $scfg->{shared}, undef, sub { > + my $target_volname =3D $class->find_free_diskname($storeid, $scfg, $tar= get_vmid); > + return $class->rename_volume($scfg, $storeid, $volname, $target_volname= , $target_vmid, $base); > + }); > +} > + > +sub rename_volume { > + my ($class, $scfg, $storeid, $source_volname, $target_volname, $vmid= , $base) =3D @_; > + > + my $cmd =3D $rbd_cmd->($scfg, $storeid, 'rename', $source_volname, $= target_volname); > + > + run_rbd_command( > + $cmd, > + errmsg =3D> "could not rename image '${source_volname}' to '${target_vo= lname}'", > + ); > + return "${storeid}:${base}${target_volname}"; > +} > + > 1; > diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm > index 3054331..adccddf 100644 > --- a/PVE/Storage/ZFSPoolPlugin.pm > +++ b/PVE/Storage/ZFSPoolPlugin.pm > @@ -659,6 +659,7 @@ sub volume_has_feature { > copy =3D> { base =3D> 1, current =3D> 1}, > sparseinit =3D> { base =3D> 1, current =3D> 1}, > replicate =3D> { base =3D> 1, current =3D> 1}, > + reassign =3D> {current =3D> 1}, > }; > =20 > my ($vtype, $name, $vmid, $basename, $basevmid, $isBase) =3D > @@ -761,4 +762,29 @@ sub volume_import_formats { > return $class->volume_export_formats($scfg, $storeid, $volname, unde= f, $base_snapshot, $with_snapshots); > } > =20 > +sub reassign_volume { > + my ($class, $scfg, $storeid, $volname, $target_vmid) =3D @_; > + > + my $base;; > + (undef, $volname, undef, $base) =3D $class->parse_volname($volname); > + > + if ($base) { > + $base =3D $base . '/'; > + } else { > + $base =3D ''; > + } > + > + $class->cluster_lock_storage($storeid, $scfg->{shared}, undef, sub { > + my $target_volname =3D $class->find_free_diskname($storeid, $scfg, $tar= get_vmid); > + return $class->rename_volume($scfg, $storeid, $volname, $target_volname= , $target_vmid, $base); > + }); > +} > + > +sub rename_volume { > + my ($class, $scfg, $storeid, $source_volname, $target_volname, $vmid= , $base) =3D @_; > + > + $class->zfs_request($scfg, 5, 'rename', "$scfg->{pool}/$source_volna= me", "$scfg->{pool}/$target_volname"); > + return "${storeid}:${base}${target_volname}"; > +} > + > 1; > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =