From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 348E26C06A for ; Fri, 19 Mar 2021 15:16:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2B175236CA for ; Fri, 19 Mar 2021 15:16:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 899B6236BD for ; Fri, 19 Mar 2021 15:16:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 324DC42905 for ; Fri, 19 Mar 2021 15:16:11 +0100 (CET) Date: Fri, 19 Mar 2021 15:16:03 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20210319134908.10558-1-f.ebner@proxmox.com> <20210319134908.10558-2-f.ebner@proxmox.com> In-Reply-To: <20210319134908.10558-2-f.ebner@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1616162913.ti6lv8kl41.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemumigrate.pm] Subject: Re: [pve-devel] [PATCH qemu-server 2/3] migrate: always check if content type images is available for target storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 14:16:13 -0000 On March 19, 2021 2:49 pm, Fabian Ebner wrote: > it's cheap and saves code. but also changes behaviour in a non-backwards-compatible fashion. previously, if a disk was already on a storage that does not have images=20 configured, and the migration leaves it on that storage, this config=20 mismatch was ignored (hence the "grandfather in existing mismatches"=20 comment). note that users might be able to migrate, but not able to=20 change storage.cfg to fix this "misconfiguration". >=20 > Signed-off-by: Fabian Ebner > --- > PVE/QemuMigrate.pm | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index 3597cc9..44cecce 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -410,11 +410,8 @@ sub sync_disks { > $log_error->("storage '$targetsid' is not available on node '$self-= >{node}'") > if !$target_scfg; > =20 > - # grandfather in existing mismatches > - if ($targetsid ne $storeid && $target_scfg) { > - $log_error->("content type 'images' is not available on storage '$targ= etsid'") > - if !$target_scfg->{content}->{images}; > - } > + $log_error->("content type 'images' is not available on storage '$t= argetsid'") > + if $target_scfg && !$target_scfg->{content}->{images}; > =20 > PVE::Storage::foreach_volid($dl, sub { > my ($volid, $sid, $volinfo) =3D @_; > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >=20 >=20 >=20 =