From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0026F1FF16B for ; Thu, 9 Jan 2025 10:52:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF26DA295; Thu, 9 Jan 2025 10:52:20 +0100 (CET) Date: Thu, 9 Jan 2025 10:51:45 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox VE development discussion Message-ID: <161581009.539.1736416305626@webmail.proxmox.com> In-Reply-To: References: <20241216091229.3142660-1-alexandre.derumier@groupe-cyllene.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev72 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH v3 qemu-server 09/11] blockdev: mirror: change aio on target if io_uring is not default. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > Alexandre Derumier via pve-devel hat am 16.12.2024 10:12 CET geschrieben: > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > This was a limitation of drive-mirror, blockdev mirror is able > to reopen image with a different aio > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer.pm | 41 ++++++++++------------------------------- > 1 file changed, 10 insertions(+), 31 deletions(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 3d7c41ee..dc12b38f 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -8207,8 +8207,16 @@ sub qemu_drive_mirror { > $dst_drive->{format} = $dst_format; > $dst_drive->{file} = $dst_path; > $dst_drive->{zeroinit} = 1 if $is_zero_initialized; > - #improve: if target storage don't support aio uring,change it to default native > - #and remove clone_disk_check_io_uring() > + > + #change aio if io_uring is not supported on target > + if ($dst_drive->{aio} && $dst_drive->{aio} eq 'io_uring') { > + my ($dst_storeid) = PVE::Storage::parse_volume_id($dst_drive->{file}); > + my $dst_scfg = PVE::Storage::storage_config($storecfg, $dst_storeid); > + my $cache_direct = drive_uses_cache_direct($dst_drive, $dst_scfg); > + if(!storage_allows_io_uring_default($dst_scfg, $cache_direct)) { > + $dst_drive->{aio} = $cache_direct ? 'native' : 'threads'; > + } > + } couldn't/shouldn't we just handle this in generate_file_blockdev? > > #add new block device > my $nodes = get_blockdev_nodes($vmid); > @@ -8514,33 +8522,6 @@ sub qemu_drive_mirror_switch_to_active_mode { > } > } > > -# Check for bug #4525: drive-mirror will open the target drive with the same aio setting as the > -# source, but some storages have problems with io_uring, sometimes even leading to crashes. > -my sub clone_disk_check_io_uring { > - my ($src_drive, $storecfg, $src_storeid, $dst_storeid, $use_drive_mirror) = @_; > - > - return if !$use_drive_mirror; > - > - # Don't complain when not changing storage. > - # Assume if it works for the source, it'll work for the target too. > - return if $src_storeid eq $dst_storeid; > - > - my $src_scfg = PVE::Storage::storage_config($storecfg, $src_storeid); > - my $dst_scfg = PVE::Storage::storage_config($storecfg, $dst_storeid); > - > - my $cache_direct = drive_uses_cache_direct($src_drive); > - > - my $src_uses_io_uring; > - if ($src_drive->{aio}) { > - $src_uses_io_uring = $src_drive->{aio} eq 'io_uring'; > - } else { > - $src_uses_io_uring = storage_allows_io_uring_default($src_scfg, $cache_direct); > - } > - > - die "target storage is known to cause issues with aio=io_uring (used by current drive)\n" > - if $src_uses_io_uring && !storage_allows_io_uring_default($dst_scfg, $cache_direct); > -} > - > sub clone_disk { > my ($storecfg, $source, $dest, $full, $newvollist, $jobs, $completion, $qga, $bwlimit) = @_; > > @@ -8598,8 +8579,6 @@ sub clone_disk { > $dst_format = 'raw'; > $size = PVE::QemuServer::Drive::TPMSTATE_DISK_SIZE; > } else { > - clone_disk_check_io_uring($drive, $storecfg, $src_storeid, $storeid, $use_drive_mirror); > - > $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10); > } > $newvolid = PVE::Storage::vdisk_alloc( > -- > 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel