From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C50DB922CC for ; Fri, 16 Feb 2024 16:57:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A113E5C2F for ; Fri, 16 Feb 2024 16:56:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Feb 2024 16:56:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E73AA4857A for ; Fri, 16 Feb 2024 16:56:41 +0100 (CET) Message-ID: <160cf77f-60b2-4f48-9f7d-7cdcdcbbbfa1@proxmox.com> Date: Fri, 16 Feb 2024 16:56:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Philipp Hufnagl References: <20231127114001.189590-1-p.hufnagl@proxmox.com> <20231127114001.189590-2-p.hufnagl@proxmox.com> From: Fiona Ebner In-Reply-To: <20231127114001.189590-2-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.221 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage v4 1/4] pbs: Move pbs_api_connect earlyer in the code X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2024 15:57:12 -0000 Am 27.11.23 um 12:39 schrieb Philipp Hufnagl: > Because it is needed later in this patch series, the method > pbs_api_connect is moved earlyer in the code Typo: /earlyer/earlier/ (also in the title) > > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Storage/PBSPlugin.pm | 63 ++++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 31 deletions(-) > > diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm > index 4320974..96373a4 100644 > --- a/src/PVE/Storage/PBSPlugin.pm > +++ b/src/PVE/Storage/PBSPlugin.pm > @@ -112,6 +112,38 @@ sub pbs_get_password { > return PVE::Tools::file_read_firstline($pwfile); > } > I don't think this is the best place to move it to, because it's now beteween the helpers for password and the helpers for the encryption key. I'd like to have it either before or after those password and key related helpers. > +# Nit: adds an extra # > +# TODO: use a client with native rust/proxmox-backup bindings to profit from > +# API schema checks and types